Skip to content

tools: fix mkcodecache when run with ASAN #32850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

tools: fix mkcodecache when run with ASAN #32850

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
tools: fix mkcodecache when run with ASAN 
Fixes: #32835
  • Loading branch information
@addaleax
addaleax committed Apr 14, 2020
commit d9b5672ecacb68caa02600aaafb48013f360ccc2
5 changes: 3 additions & 2 deletions tools/code_cache/mkcodecache.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ int main(int argc, char* argv[]) {

// Create a new Isolate and make it the current one.
Isolate::CreateParams create_params;
create_params.array_buffer_allocator =
ArrayBuffer::Allocator::NewDefaultAllocator();
create_params.array_buffer_allocator_shared.reset(
ArrayBuffer::Allocator::NewDefaultAllocator());
Isolate* isolate = Isolate::New(create_params);
{
Isolate::Scope isolate_scope(isolate);
Expand All @@ -65,6 +65,7 @@ int main(int argc, char* argv[]) {
out << cache;
out.close();
}
isolate->Dispose();

v8::V8::ShutdownPlatform();
return 0;
Expand Down