Skip to content

lib: coerce -0 into 0 for process APIs #32841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 2 commits into from
Closed

lib: coerce -0 into 0 for process APIs #32841

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2dfd02
lib: coerce `-0` into `0` for process APIs
HarshithaKP Apr 14, 2020
a315827
fixup: address review comments
HarshithaKP Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
lib: coerce -0 into 0 for process APIs 
Fixes: #32750
  • Loading branch information
@HarshithaKP
HarshithaKP committed Apr 14, 2020
commit c2dfd0298445cbc71052d7ab600fb1e4c46a3e56
3 changes: 3 additions & 0 deletions lib/internal/bootstrap/switches/does_own_process_state.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ function wrapPosixCredentialSetters(credentials) {
function wrapIdSetter(type, method) {
return function(id) {
validateId(id, 'id');
// Coerce -0 into 0, because that is the most reasonable thing
// for system calls
if (id === -0) id = 0;
// Result is 0 on success, 1 if credential is unknown.
const result = method(id);
Comment thread
himself65 marked this conversation as resolved.
Outdated
if (result === 1) {
Expand Down