Skip to content

doc: improve net docs #32811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

doc: improve net docs #32811

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
24d420a
doc: improve net docs
ronag Apr 13, 2020
a3715af
Apply suggestions from code review
ronag Apr 13, 2020
f14c446
fixup: fix link
ronag Apr 13, 2020
f63e0c9
fixup: remove misleading comment
ronag Apr 13, 2020
b70cdcf
fixup: add note regarding TCP rst
ronag Apr 13, 2020
c7837ad
fixup: apply suggestion
ronag Apr 13, 2020
9047905
Update doc/api/net.md
ronag Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: add note regarding TCP rst
  • Loading branch information
@ronag
ronag committed Apr 13, 2020
commit b70cdcfe5199c07d7d6130bba6c779c60a54993b
3 changes: 2 additions & 1 deletion doc/api/net.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,8 @@ added: v0.1.90
* `error` {Object}
* Returns: {net.Socket}

Ensures that no more I/O activity happens on this socket.
Ensures that no more I/O activity happens on this socket. This destroys
the stream but does not explicitly cause a TCP stream reset (RST).
Copy link
Copy Markdown
Member Author

@ronag ronag Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lpinca: please note updated version, better?

Copy link
Copy Markdown
Member

@lpinca lpinca Apr 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would honestly not add those details that I think are confusing for most users. "Destroys the stream and closes the connection" is enough. Interested users can dig by themselves to see what happens under the hood.

Copy link
Copy Markdown
Member Author

@ronag ronag Apr 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to your suggestion.


See, [`writable.destroy()`][] for further details.
Comment thread
ronag marked this conversation as resolved.
Outdated

Expand Down