Skip to content

http: refactor agent 'free' handler #32801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 4 commits into from
Closed

http: refactor agent 'free' handler #32801

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bcbf1d7
http: refactor agent 'free' handler
ronag Apr 12, 2020
b0c8a22
http: agent use once helper
ronag Apr 12, 2020
f88a185
Update lib/_http_agent.js
ronag Apr 14, 2020
41af730
fixup
ronag Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
http: agent use once helper
  • Loading branch information
@ronag
ronag committed Apr 12, 2020
commit b0c8a22f88cde6d8fe5a12711c0e7c3f09df3e8f
10 changes: 4 additions & 6 deletions lib/_http_agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ const {
ERR_INVALID_ARG_TYPE,
},
} = require('internal/errors');
const { once } = require('internal/util');

const kOnKeylog = Symbol('onkeylog');
// New Agent code.

Expand Down Expand Up @@ -268,12 +270,8 @@ Agent.prototype.createSocket = function createSocket(req, options, cb) {

debug('createConnection', name, options);
options.encoding = null;
let called = false;

const oncreate = (err, s) => {
if (called)
return;
called = true;
const oncreate = once((err, s) => {
if (err)
return cb(err);
if (!this.sockets[name]) {
Expand All @@ -283,7 +281,7 @@ Agent.prototype.createSocket = function createSocket(req, options, cb) {
debug('sockets', name, this.sockets[name].length);
installListeners(this, s, options);
cb(null, s);
};
});

const newSocket = this.createConnection(options, oncreate);
if (newSocket)
Expand Down