Skip to content

stream: fix _final and 'prefinish' timing #32780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
+88 −23
Closed

stream: fix _final and 'prefinish' timing #32780

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be9f726
stream: fix _final and 'prefinish' timing
ronag Apr 11, 2020
469766e
fixup: comments
ronag Apr 15, 2020
571eb88
fixup: missing needFinish
ronag Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: missing needFinish
  • Loading branch information
@ronag
ronag committed Apr 15, 2020
commit 571eb8893763991da627834bf7260f702ab60edf
7 changes: 3 additions & 4 deletions lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,10 +635,7 @@ function callFinal(stream, state) {
state.pendingcb--;
if (err) {
errorOrDestroy(stream, err, state.sync);
} else {
// Backwards compat. Don't check needFinish() here.
// Some streams assume 'finish' will be emitted
// even if stream has been destroyed.
} else if (needFinish(state)) {
state.prefinished = true;
stream.emit('prefinish');
// Backwards compat. Don't check state.sync here.
Expand Down Expand Up @@ -682,6 +679,8 @@ function finish(stream, state) {
if (state.errorEmitted)
return;

// TODO(ronag): This could occur after 'close' is emitted.

state.finished = true;
stream.emit('finish');

Expand Down