Skip to content

stream: simplify Transform stream implementation #32763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 8 commits into from
Closed

stream: simplify Transform stream implementation #32763

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6099382
stream: simplify Transform stream implementation
ronag Apr 10, 2020
8a54b1f
fixup: zlib
ronag Apr 10, 2020
8cf4a58
fixup: zlib
ronag Apr 10, 2020
2f5da16
fixup: test
ronag Apr 10, 2020
e12e6b4
fixup: cleanup
ronag Apr 10, 2020
5cd52b7
fixup: lint
ronag Apr 10, 2020
dce04fb
fixup
ronag Apr 10, 2020
6d59617
fixup: backwards compat notes
ronag Apr 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: zlib
  • Loading branch information
@ronag
ronag committed Apr 10, 2020
commit 8cf4a58389c2f0fe9a281d7a0ff04f61d9c5513c
2 changes: 2 additions & 0 deletions lib/_stream_transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ Transform.prototype._transform = function(chunk, encoding, callback) {

Transform.prototype._write = function(chunk, encoding, callback) {
const rState = this._readableState;
const wState = this._writableState;
const length = rState.length;

this._transform(chunk, encoding, (err, val) => {
Expand All @@ -143,6 +144,7 @@ Transform.prototype._write = function(chunk, encoding, callback) {
}

if (
wState.ended ||
length === rState.length ||
rState.length < rState.highWaterMark ||
rState.length === 0
Expand Down