Skip to content

buffer: mark pool ArrayBuffer as untransferable #32759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 2 commits into from
Closed

buffer: mark pool ArrayBuffer as untransferable #32759

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3efce9
buffer: mark pool ArrayBuffer as untransferable
addaleax Apr 10, 2020
46afefd
fixup! buffer: mark pool ArrayBuffer as untransferable
addaleax Apr 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! buffer: mark pool ArrayBuffer as untransferable
  • Loading branch information
@addaleax
addaleax committed Apr 10, 2020
commit 46afefd8b0600667cf46e16a7fa2fca528ca0114
4 changes: 2 additions & 2 deletions test/parallel/test-buffer-pool-untransferable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const { MessageChannel } = require('worker_threads');

Expand All @@ -12,7 +12,7 @@ const b = Buffer.from('hello world');
assert.strictEqual(a.buffer, b.buffer);
const length = a.length;

const { port1, port2 } = new MessageChannel();
const { port1 } = new MessageChannel();
port1.postMessage(a, [ a.buffer ]);

// Verify that the pool ArrayBuffer has not actually been transfered:
Expand Down