Skip to content

doc: updated guidance for n-api changes #32721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 2 commits into from
Closed

doc: updated guidance for n-api changes #32721

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a4018
doc: updated guidance for n-api changes
mhdawson Apr 8, 2020
c954874
Update doc/guides/collaborator-guide.md
mhdawson Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: updated guidance for n-api changes 
Add js_native_api.h and js_native_api_types.h to the list
of files covered by the N-API guidance as these were
broken out of the files referenced.

Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
@mhdawson
mhdawson committed Apr 8, 2020
commit 81a4018c139424b725b510176bbca80d86f1432d
4 changes: 2 additions & 2 deletions doc/guides/collaborator-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ For pull requests introducing new core modules:
### Additions to N-API

N-API provides an ABI-stable API guaranteed for future Node.js versions. N-API
additions call for unusual care and scrutiny. If a change adds to `node_api.h`
or `node_api_types.h`, consult [the relevant
additions call for unusual care and scrutiny. If a change adds to `node_api.h`,
`js_native_api.h`, `node_api_types.h` or `js_native_api_types.h`, consult [the relevant
Comment thread
mhdawson marked this conversation as resolved.
Outdated
guide](https://github.com/nodejs/node/blob/master/doc/guides/adding-new-napi-api.md).

### Deprecations
Expand Down