Skip to content

report: fix stderr matching for fatal error #32699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gengjiawen wants to merge 1 commit into from
Closed

report: fix stderr matching for fatal error #32699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
report: fix stderr matching for fatal error
  • Loading branch information
@gengjiawen
gengjiawen committed Apr 7, 2020
commit d9ddd2f2e30bc0f5998f19ec9b813d1a7384e3d9
4 changes: 2 additions & 2 deletions test/report/test-report-fatal-error.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ const ARGS = [
assert.strictEqual(reports.length, 0);

const lines = child.stderr.split('\n');
// Skip over unavoidable free-form output from V8.
const report = lines[1];
// Skip over unavoidable free-form output and gc log from V8.
const report = lines.find((i) => i.startsWith('{'));
const json = JSON.parse(report);

assert.strictEqual(json.header.threadId, null);
Expand Down