Skip to content

build: turn warnings into errors for node sources #32685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danbev wants to merge 5 commits into from
Closed

build: turn warnings into errors for node sources #32685

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e3988d
build: turn warnings into errors for node sources
danbev Apr 6, 2020
2379516
tools: fix redundant-move warning in inspector
danbev Apr 6, 2020
b9fa8f3
build: add --error-on-warn configure flag
danbev Apr 17, 2020
1d0456c
squash: remove -Werror when error_on_warn is false
danbev Apr 24, 2020
9890e67
squash: set error_on_warn to false instead of 0
danbev Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tools: fix redundant-move warning in inspector 
Currently, the following warning is generated from the inspector
protocol:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:
In member function
‘virtual std::unique_ptr<node::inspector::protocol::Value>
    node::inspector::protocol::ListValue::clone() const’:
/out/Release/obj/gen/src/node/inspector/protocol/Protocol.cpp:739:21:
error: redundant move in return statement [-Werror=redundant-move]
  739 |     return std::move(result);
      |            ~~~~~~~~~^~~~~~~~

This commit removes the move for DictionaryValue and ListValue.
  • Loading branch information
@danbev
danbev committed Apr 17, 2020
commit 237951615498b8ea3c51856e81611be85f80412f
4 changes: 2 additions & 2 deletions tools/inspector_protocol/lib/Values_cpp.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,7 +606,7 @@ std::unique_ptr<Value> DictionaryValue::clone() const
DCHECK(value != m_data.cend() && value->second);
result->setValue(key, value->second->clone());
}
return std::move(result);
return result;
}

DictionaryValue::DictionaryValue()
Expand Down Expand Up @@ -647,7 +647,7 @@ std::unique_ptr<Value> ListValue::clone() const
std::unique_ptr<ListValue> result = ListValue::create();
for (const std::unique_ptr<protocol::Value>& value : m_data)
result->pushValue(value->clone());
return std::move(result);
return result;
}

ListValue::ListValue()
Expand Down