Skip to content

doc: additional note in README(.md) informing users that it is advise… #32655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haqer1 wants to merge 4 commits into from
Closed

doc: additional note in README(.md) informing users that it is advise… #32655

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9bd6618
doc: additional note in README(.md) informing users that it is advise…
haqer1 Apr 4, 2020
2e103ed
doc: apply suggestion from code review
haqer1 Apr 9, 2020
945cce5
doc: additional note in README(.md) informing users that it is advise…
haqer1 Oct 28, 2020
69d81a9
doc: additional note in README(.md) informing users that it is advise…
haqer1 Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: additional note in README(.md) informing users that it is advise… 
…d to import the full set of trusted release keys (rather than an individual key) (reconciled with another suggestion from code review)

The OP finds his original suggestion more descriptive & more user-friendly, but prefers to move on since that suggestion is stalled in favor of much shorter verbiage

Co-Authored-By: Myles Borins <mylesborins@google.com>

Fixes: #32559
  • Loading branch information
@haqer1
haqer1 committed Oct 28, 2020
commit 945cce5fb06cb451a96888e36dc292b144c332d9
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,8 +565,7 @@ GPG keys used to sign Node.js releases:
* **Shelley Vohr** &lt;shelley.vohr@gmail.com&gt;
`B9E2F5981AA6E0CD28160D9FF13993A75599653C`

To avoid nuances involved in verification of a sub-key possibly used to sign a
release, import the full set of trusted release keys:
To import the full set of trusted release keys (including subkeys possibly used to sign releases):

```shell
gpg --keyserver pool.sks-keyservers.net --recv-keys 4ED778F539E3634C779C87C6D7062848A1AB005C
Expand Down