Skip to content

[v12.x] ESM Module update #32610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 12 commits into from
Closed

[v12.x] ESM Module update #32610

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c0e6e60
tools: update minimist@1.2.5
Trott Mar 14, 2020
a1a282f
esm: import.meta.resolve with nodejs: builtins
guybedford Dec 19, 2019
37aee30
module: package "exports" error refinements
guybedford Feb 3, 2020
e147f61
esm: remove unused parameter on module.instantiate
himself65 Mar 8, 2020
07b77a3
module: add hook for global preload code
hybrist Mar 3, 2020
9da5813
doc: import clarifications with links to MDN
aldeed Mar 18, 2020
ef27b5a
doc: improve wording in esm.md
Trott Mar 22, 2020
5c7c915
doc: fix lint warning in doc/api/esm.md
richardlau Mar 24, 2020
17a18a1
doc: remove unnecessary "obvious(ly)" modifiers in esm.md
Trott Mar 24, 2020
26e44c9
build: add mjs extension to lint-js
nschonni Mar 8, 2020
4ab422a
doc: update conditional exports recommendations
guybedford Mar 4, 2020
fce87a5
doc: esm spec bug
MylesBorins Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: improve wording in esm.md 
Simplify complex sentence. Remove use of "straightforward".

PR-URL: #32427
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
  • Loading branch information
@Trott @MylesBorins
Trott authored and MylesBorins committed Apr 3, 2020
commit ef27b5aa3162cb95bced41d9385dd5e9035500b8
4 changes: 2 additions & 2 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,8 +637,8 @@ stateless):

##### Approach #2: Isolate State

The most straightforward `package.json` would be one that defines the separate
CommonJS and ES module entry points directly:
A `package.json` file can define the separate CommonJS and ES module entry
points directly:

<!-- eslint-skip -->
```js
Expand Down