Skip to content

[v12.x] actions update / remove travis #32608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 16 commits into from
Closed

[v12.x] actions update / remove travis #32608

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b408413
src: add build Github Action
gengjiawen Jan 2, 2020
2e08042
build: add GitHub actions to run linters
richardlau Jan 12, 2020
8ddb39e
build: fix step name in GitHub Actions workflow
richardlau Jan 12, 2020
bf04e09
build: fix macos runner type in GitHub Action
himself65 Jan 12, 2020
9a3e059
build: do not use setup-node in build workflows
richardlau Jan 14, 2020
57f6b5a
build: build docs in GitHub Actions CI workflow
richardlau Jan 24, 2020
c2e00ed
build: annotate markdown lint failures in pull requests
richardlau Mar 20, 2020
9d80c47
build: drop Travis in favor of Actions
cclauss Sep 5, 2019
cd6f327
fixup: 2.7 for windows
MylesBorins Apr 2, 2020
aa7ca3c
fixup: 2.7 linux
MylesBorins Apr 2, 2020
ff117fb
fixup: 2.7 macos
MylesBorins Apr 2, 2020
b176276
fixup: linux
MylesBorins Apr 2, 2020
c734115
fixup: windows
MylesBorins Apr 2, 2020
4739111
fixup: windows 2016
MylesBorins Apr 2, 2020
833482d
fixup: windows oops
MylesBorins Apr 2, 2020
8cb4db0
fixup: don't get rid of python 3 test
MylesBorins Apr 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
build: do not use setup-node in build workflows 
The setup-node GitHub Action installs problem matchers that happen
to match the warning message format of Visual Studio's C/C++ compiler.
This is resulting in all of our pull requests being annotated with
`Unchanged files with check annotations` which are confusing to new
contributors as they are not due to the changes in the pull request.

The action is used to run `npx envinfo` to dump some information into
the logs before the actual build. All GitHub hosted runners already
have a version of Node.js installed (12.x at the time of this commit)
which we can use to run `envinfo`. Remove the action to avoid using
the problematic problem matcher.

PR-URL: #31349
Fixes: #31347
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@richardlau @MylesBorins
richardlau authored and MylesBorins committed Apr 2, 2020
commit 9a3e059d44a2a8616d35b90a57534ae254426b9f
12 changes: 0 additions & 12 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
with:
node-version: 13.x
- name: Environment Information
run: npx envinfo
- name: Build
Expand All @@ -19,10 +15,6 @@ jobs:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
with:
node-version: 13.x
- name: Environment Information
run: npx envinfo
- name: Install deps
Expand All @@ -33,10 +25,6 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
with:
node-version: 13.x
- name: Environment Information
run: npx envinfo
- name: Build
Expand Down