Skip to content

test: check bundled binaries are signed on macOS #32522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardlau wants to merge 1 commit into from
Closed

test: check bundled binaries are signed on macOS #32522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: check bundled binaries are signed on macOS 
For notarization on macOS all packaged binaries must be signed. Add a
regression test to check that known binaries from our dependencies
(at the time of this commit term-size via npm) are signed.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@richardlau
richardlau committed Mar 27, 2020
commit 523c40ea02c667224c2e4322d27aba6dd3af4654
31 changes: 31 additions & 0 deletions test/parallel/test-macos-signed-deps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
'use strict';

// Notarization on macOS requires all binaries to be signed.
// We sign our own binaries but check here if any binaries from our dependencies
// (e.g. npm) are signed.
const common = require('../common');

if (!common.isOSX) {
common.skip('macOS specific test');
}

const assert = require('assert');
const { spawnSync } = require('child_process');
const path = require('path');

const debuglog = require('util').debuglog('test');

const binaries = [
'deps/npm/node_modules/term-size/vendor/macos/term-size',
];

for (const testbin of binaries) {
const bin = path.resolve(__dirname, '..', '..', testbin);
debuglog(`Checking ${bin}`);
const cp = spawnSync('codesign', [ '-vvvv', bin ], { encoding: 'utf8' });
debuglog(cp.stdout);
debuglog(cp.stderr);
assert.strictEqual(cp.signal, null);
assert.strictEqual(cp.status, 0, `${bin} does not appear to be signed.\n` +
`${cp.stdout}\n${cp.stderr}`);
}