Skip to content

net: wait for shutdown to complete before closing #32491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 6 commits into from
Closed

net: wait for shutdown to complete before closing #32491

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3bf1c08
net: wait for shutdown to complete before closing
ronag Mar 25, 2020
93c6f75
fixup: test
ronag Mar 25, 2020
c485b6a
fixup: test
ronag Mar 25, 2020
871866e
fixup: tst
ronag Mar 25, 2020
fb389dc
fixup: test
ronag Mar 25, 2020
a9382cb
fixup: apply win10 fix
ronag Mar 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: apply win10 fix
  • Loading branch information
@ronag
ronag committed Mar 25, 2020
commit a9382cbe13d8aff2058b5167c6edd3ef54d5f044
10 changes: 10 additions & 0 deletions lib/internal/stream_base_commons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,16 @@ function onStreamRead(arrayBuffer) {
if (stream[kMaybeDestroy])
stream.on('end', stream[kMaybeDestroy]);

// TODO(ronag): Without this `readStop`, `onStreamRead`
// will be called once more (i.e. after Readable.ended)
// on Windows causing a ECONNRESET, failing the
// test-https-truncate test.
if (handle.readStop) {
const err = handle.readStop();
if (err)
return stream.destroy(errnoException(err, 'read'));
}

// Push a null to signal the end of data.
// Do it before `maybeDestroy` for correct order of events:
// `end` -> `close`
Expand Down