Skip to content

feat(fs): Make parameters optional for readSync #32460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lholmquist wants to merge 4 commits into from
Closed

feat(fs): Make parameters optional for readSync #32460

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c91f09e
fs: Make parameters optional for readSync
lholmquist Mar 24, 2020
7115ba9
squash: fix typo
lholmquist Mar 24, 2020
c2bb51b
squash: fix up tests
lholmquist Mar 25, 2020
7f68e77
squash: update docs
lholmquist Mar 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: fix typo
  • Loading branch information
@lholmquist
lholmquist committed Mar 30, 2020
commit 7115ba958faf3e3cef021a4d28540e547489df23
2 changes: 1 addition & 1 deletion test/parallel/test-fs-readSync-optional-params.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ assert.deepStrictEqual(defaultBuffer2, expected);
// Test passing in options
const result3 = fs.readSync(fd, defaultBuffer3, {
offset: 0,
lenght: defaultBuffer3.length,
length: defaultBuffer3.length,
position: 0
});

Expand Down