Skip to content

build: rework ASAN build on Actions #32352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 1 commit into from
Closed

build: rework ASAN build on Actions #32352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: rework ASAN build on Actions 
Changed from Debug build to Release build to avoid out of memory issues
during the link step. This should also speed up the build.

Commented out the test runner for now, since there are too many ASAN
warnings there to be useful. We should re-enable the test runner once
our ASAN warnings are fixed.

Simplify the environment: instead of running on a container, runs
directly on the host. With this, ASAN build looks identical to other
builds in GitHub Actions, with the exception of the `--enable-asan`
flag.

Ref: https://github.com/nodejs/node/issue/32257
Ref: #32324
  • Loading branch information
@mmarchini
mmarchini committed Mar 19, 2020
commit daf2adda33afa3569bc24778b050a9942c3686a3
36 changes: 16 additions & 20 deletions .github/workflows/ASAN.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,19 @@ name: node ASAN
on: [push, pull_request]

jobs:
ubuntu-build:
runs-on: ubuntu-latest
container: gengjiawen/node-build:2020-02-14
steps:
- uses: actions/checkout@v2
- name: Build
# TODO(mmarchini): With V8 8.1, GitHub Actions doesn't have enough
# memory to build with debug and ASAN. Allow this build to fail until
# we figure out a workaround, or until we update to 8.2 (where build
# is passing).
continue-on-error: true
run: |
npx envinfo
./configure --debug --enable-asan --ninja && ninja -C out/Debug
- name: Test
env:
ASAN_OPTIONS: halt_on_error=0
continue-on-error: true
run: |
python3 tools/test.py -J --mode=debug
build-linux-asan:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
run: ./configure --enable-asan && make -j2
# TODO(mmarchini): re-enable tests when we fix all issues pointed out
# by ASAN
# - name: Test
# env:
# ASAN_OPTIONS: halt_on_error=0
# continue-on-error: true
# run: |
# python3 tools/test.py -J