Skip to content

test: add a missing common.mustCall #32305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 2 commits into from
Closed

test: add a missing common.mustCall #32305

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
202abc3
test: add a missing common.mustCall
HarshithaKP Mar 16, 2020
d209f43
fixup: address review comment
HarshithaKP Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: add a missing common.mustCall
  • Loading branch information
@HarshithaKP
HarshithaKP committed Mar 16, 2020
commit 202abc34b01117c3d53d7719253b29417f3ac15f
4 changes: 2 additions & 2 deletions test/parallel/test-process-getactiverequests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
'use strict';

require('../common');
const common = require('../common');
const assert = require('assert');
const fs = require('fs');

for (let i = 0; i < 12; i++)
fs.open(__filename, 'r', () => {});
fs.open(__filename, 'r', common.mustCall(() => {}));
Comment thread
addaleax marked this conversation as resolved.
Outdated

assert.strictEqual(process._getActiveRequests().length, 12);