Skip to content

src: replace handle dereference with ContainerOf macro #32298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 2 commits into from
Closed

src: replace handle dereference with ContainerOf macro #32298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e522af
src: replace handle dereference with ContainerOf
HarshithaKP Mar 16, 2020
c8dbd57
fixup: address review comment
HarshithaKP Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: replace handle dereference with ContainerOf 
this was influenced by #32269
  • Loading branch information
@HarshithaKP
HarshithaKP committed Mar 16, 2020
commit 3e522af26e545cc244b6ff9e5f32611eec0b6b71
2 changes: 1 addition & 1 deletion src/process_wrap.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ class ProcessWrap : public HandleWrap {
static void OnExit(uv_process_t* handle,
int64_t exit_status,
int term_signal) {
ProcessWrap* wrap = static_cast<ProcessWrap*>(handle->data);
ProcessWrap* wrap = ContainerOf(&ProcessWrap::process_, handle);
CHECK_NOT_NULL(wrap);
Comment thread
addaleax marked this conversation as resolved.
Outdated
CHECK_EQ(&wrap->process_, handle);

Expand Down