Skip to content

stream: don't emit 'finish' after 'error' #32275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: don't emit 'finish' after 'error' #32275

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48e7a2e
stream: don't emit 'finish' after 'error'
ronag Mar 14, 2020
271f119
Update lib/_stream_writable.js
ronag Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: don't emit 'finish' after 'error'
  • Loading branch information
@ronag
ronag committed Mar 15, 2020
commit 48e7a2e6bcf8c230accdeb86af13f757cc38f12e
4 changes: 4 additions & 0 deletions lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,6 +666,10 @@ function finishMaybe(stream, state, sync) {

function finish(stream, state) {
state.pendingcb--;
if (state.errorEmitted) {
return;
}
Comment thread
ronag marked this conversation as resolved.
Outdated

state.finished = true;
stream.emit('finish');

Expand Down
1 change: 1 addition & 0 deletions test/parallel/test-stream-writable-write-writev-finish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ const stream = require('stream');
process.nextTick(cb);
};
w.on('error', common.mustCall());
w.on('finish', common.mustNotCall());
w.on('prefinish', () => {
w.write("shouldn't write in prefinish listener");
});
Expand Down