Skip to content

esm: doc & validate source values for formats #32202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bmeck wants to merge 6 commits into from
Closed

esm: doc & validate source values for formats #32202

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
614ec8e
esm: doc & validate source values for formats
bfarias-godaddy Mar 11, 2020
d2c1e51
Update doc/api/esm.md
bmeck May 18, 2020
ecb72bc
Update doc/api/esm.md
bmeck May 18, 2020
d7d8024
Update doc/api/esm.md
bmeck May 19, 2020
759e4f2
Update doc/api/esm.md
bmeck May 19, 2020
525554d
Update doc/api/esm.md
bmeck May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update doc/api/esm.md 
Co-authored-by: Derek Lewis <DerekNonGeneric@inf.is>
  • Loading branch information
@bmeck
bmeck and Derek Lewis authored May 19, 2020
commit 525554d4e3e0ee33878bfd32c0254fbb484b9bb7
14 changes: 9 additions & 5 deletions doc/api/esm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,15 +1205,19 @@ of the following:
| `'builtin'` | Load a Node.js builtin module | Not applicable |
| `'commonjs'` | Load a Node.js CommonJS module | Not applicable |
| `'dynamic'` | Use a [dynamic instantiate hook][] | Not applicable |
| `'json'` | Load a JSON file | array buffer, string, or typed array |
| `'module'` | Load a standard JavaScript module (ES module) | array buffer, string, or typed array |
| `'wasm'` | Load a WebAssembly module | array buffer, or typed array |
| `'json'` | Load a JSON file | { [ArrayBuffer][], [string][], [TypedArray][] } |
| `'module'` | Load an ES module | { [ArrayBuffer][], [string][], [TypedArray][] } |
| `'wasm'` | Load a WebAssembly module | { [ArrayBuffer][], [string][], [TypedArray][] } |

Note: These types all correspond to classes defined in ECMAScript.

* The specific [ArrayBuffer][] object is a [SharedArrayBuffer][].
* The specific [string][] object is not the class constructor, but an instance.
* The specific [TypedArray][] object is a [Uint8Array][].

Note: If the source value of a text-based format (i.e., `'json'`, `'module'`) is
not a string, it will be converted to a string using [`util.TextDecoder`][].

Note: `Buffer` is a form of typed array.

```js
/**
* @param {string} url
Expand Down