Skip to content

esm: port loader code to JS #32201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 7 commits into from
Closed

esm: port loader code to JS #32201

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a321c5
esm: port loader code to JS
addaleax Mar 7, 2020
1f20296
fixup! esm: port loader code to JS
addaleax Mar 11, 2020
49c4f53
fixup! esm: port loader code to JS
addaleax Mar 11, 2020
1f93185
fixup! esm: port loader code to JS
addaleax Mar 12, 2020
2038dda
fixup! fixup! esm: port loader code to JS
addaleax Mar 12, 2020
826c63b
fixup! esm: port loader code to JS
addaleax Mar 12, 2020
bab3482
fixup! fixup! esm: port loader code to JS
addaleax Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! esm: port loader code to JS 
Co-Authored-By: Bradley Farias <bradley.meck@gmail.com>
  • Loading branch information
@addaleax @bmeck
addaleax and bmeck authored Mar 12, 2020
commit 826c63bca1fefd4371b61f6885ea67541ebbbfec
10 changes: 4 additions & 6 deletions lib/internal/modules/esm/resolve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,12 +311,10 @@ function resolveExportsTargetString(
return subpathResolved;
}

function isArrayIndex(key) {
const keyStr = `${key}`;
if (`${+keyStr}` !== keyStr) return false;
key >>>= 0;
if (ObjectIs(key, 0)) return true;
return key > 0 && key < 0xFFFF_FFFF;
function isArrayIndex(key /* string */) { /* -> boolean */
const keyNum = +key;
if (`${keyNum}` !== key) return false;
return keyNum >= 0 && keyNum < 0xFFFF_FFFF;
}

function resolveExportsTarget(
Expand Down