Skip to content

stream: avoid destroying http1 objects #32197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 3 commits into from
Closed

stream: avoid destroying http1 objects #32197

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70eabc1
stream: avoid destroying http1 objects
ronag Mar 11, 2020
bed9a32
fixup: don't depend on private properties
ronag Mar 11, 2020
1415464
fixup: suggestions
ronag Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: don't depend on private properties
  • Loading branch information
@ronag
ronag committed Mar 11, 2020
commit bed9a326757d9f9328e7f8102e386a6abab8fdf5
4 changes: 2 additions & 2 deletions lib/internal/streams/pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ let createReadableStreamAsyncIterator;
function isIncoming(stream) {
return (
stream.socket &&
typeof stream._dump === 'function' &&
typeof stream._consuming === 'boolean' &&
typeof stream.complete === 'boolean' &&
ArrayIsArray(stream.rawTrailers) &&
ArrayIsArray(stream.rawHeaders)
);
}
Expand Down