Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
108 commits
Select commit Hold shift + click to select a range
31e4a0d
src: Handle bad callback in asyc_wrap
HarshithaKP Feb 25, 2020
89987b3
test: remove common.expectsInternalAssertion
Trott Feb 29, 2020
83e9a3e
test: add coverage for FSWatcher exception
Trott Mar 1, 2020
a727b13
crypto: make update(buf, enc) ignore encoding
bnoordhuis Feb 13, 2020
4ac1ce1
src: introduce node_sockaddr
jasnell Mar 3, 2020
5f12595
doc: update email address in authors
yaelhe Feb 29, 2020
c0ba6ec
meta: move thefourtheye to TSC Emeritus
Trott Mar 3, 2020
31ec443
benchmark: remove problematic tls params
mscdex Feb 16, 2020
50094de
doc: remove em dashes
Trott Mar 4, 2020
a037770
src,http2: introduce node_http_common
jasnell Mar 3, 2020
3befe80
async_hooks: fix ctx loss after nested ALS calls
puzpuzpuz Mar 4, 2020
2585b81
stream: add comments to pipeline implementation
ronag Mar 2, 2020
55486bc
events: fix removeListener for Symbols
fuxingZhang Feb 18, 2020
1ffa9f3
http: fix socket re-use races
ronag Feb 28, 2020
8e43568
test: update tests for larger Buffers
jakobkummerow Jan 20, 2020
7c739aa
build: enable backtrace when V8 is built for PPC and S390x
targos Oct 29, 2019
dd83bd2
wasi: add returnOnExit option
cjihrig Mar 5, 2020
74edcc5
test: apply camelCase in test-net-reconnect-error
Trott Mar 6, 2020
da7349d
test: remove superfluous checks in test-net-reconnect-error
Trott Mar 6, 2020
2e5f81f
doc: fix broken links in benchmark README
Trott Mar 6, 2020
1428de8
test: add WASI test for path_link()
cjihrig Mar 6, 2020
a79b8fa
doc: document fs.watchFile() bigint option
cjihrig Mar 6, 2020
7b9b578
src: fix -Winconsistent-missing-override warning
cjihrig Mar 6, 2020
e9f9d07
src: fix -Wreorder compiler warning
cjihrig Mar 6, 2020
97965f5
doc: document self-referencing a package name
giltayar Feb 7, 2020
c106a85
fs: fix valid id range on chown, lchown, fchown
himself65 Feb 9, 2020
bd75688
src: add missing namespace using statements in node_watchdog.h
legendecas Mar 6, 2020
296f35b
src: improve KVStore API
lundibundi Feb 13, 2020
cc27846
src: simplify node_worker.cc using new KVStore API
lundibundi Feb 13, 2020
6545d1a
test: allow EAI_FAIL in test-net-dns-error.js
batrla Feb 13, 2020
50c5eb4
doc: link setRawMode() from signal docs
addaleax Mar 4, 2020
f07d423
build: allow passing multiple libs to pkg_config
andred Mar 2, 2020
6413524
build: allow use of system-installed brotli
andred Mar 2, 2020
3d64c9e
test: changed function to arrow function
ProdipRoy89 Mar 2, 2020
862cd2b
test: use index.js if package.json "main" is empty
bnoordhuis Mar 2, 2020
cba75c5
src: handle NULL env scenario
HarshithaKP Feb 21, 2020
6a9654a
test: increase test timeout to prevent flakiness
BridgeAR Feb 10, 2020
02ebc81
doc: revise tools/icu/README.md
Trott Mar 7, 2020
4d5981b
async_hooks: add sync enterWith to ALS
Qard Feb 25, 2020
710c905
n-api: define release 6
Mar 3, 2020
6f9f2c5
test: warn when inspector process crashes
mmarchini Mar 7, 2020
e1347b4
cli: allow --jitless V8 flag in NODE_OPTIONS
andrewdotn Mar 4, 2020
e11f38c
benchmark: refactor helper into a class
BridgeAR Feb 12, 2020
5d92cec
benchmark: add `test` and `all` options and improve errors"
BridgeAR Feb 12, 2020
92cc406
test: refactor all benchmark tests to use the new test option
BridgeAR Feb 12, 2020
ddb8824
benchmark: remove special test entries
BridgeAR Feb 12, 2020
4640ea2
stream: don't destroy final readable stream in pipeline
ronag Mar 5, 2020
90a4d43
stream: combine properties using defineProperties
antsmartian Feb 10, 2020
1e05ddf
stream: improve writable.write() performance
mscdex Feb 3, 2020
1c4f4cc
fs: fix writeFile[Sync] for non-seekable files
mildsunrise Feb 28, 2020
9d1b1a3
stream: simplify Writable.write
ronag Dec 31, 2019
7ce1cc9
stream: simplify pipeline
ronag Jan 18, 2020
4b04bf8
stream: re-use legacy destroyer
ronag Jan 21, 2020
f263659
stream: eos make const state const
ronag Mar 1, 2020
258a80d
src: create a getter for kernel version
juanarbol Mar 10, 2020
2388a40
src: make aliased_buffer.h self-contained
joyeecheung Feb 20, 2020
5127c70
src: refactor debug category parsing
joyeecheung Feb 20, 2020
6aa797b
src: implement per-process native Debug() printer
joyeecheung Feb 20, 2020
bb41383
tools: use per-process native Debug() printer in mkcodecache
joyeecheung Feb 20, 2020
188f1d2
test: improve test-debug-usage
Trott Mar 8, 2020
2d39369
doc: remove personal pronoun usage in addons.md
Trott Mar 8, 2020
fa99fb2
doc: remove personal pronoun usage in errors.md
Trott Mar 8, 2020
618b389
doc: remove personal pronoun usage in fs.md
Trott Mar 8, 2020
7de4dfb
doc: remove personal pronoun usage in policy.md
Trott Mar 8, 2020
1e9a251
src: use C++ style for struct with initializers
sam-github Mar 7, 2020
3c06316
build: workaround for gclient python3 issues
mmarchini Mar 7, 2020
bc1e357
doc: change worker.takeHeapSnapshot to getHeapSnapshot
Flarna Mar 3, 2020
4589863
test: always skip vm-timeout-escape-queuemicrotask
lundibundi Feb 27, 2020
eaf6723
vm: refactor value validation with internal/validators.js
lundibundi Jan 23, 2020
607ac90
lib: improve value validation utils
lundibundi Jan 23, 2020
ff58854
fs: return first folder made by mkdir recursive
Jan 29, 2020
897b1d2
lib: move isLegalPort to validators, refactor
jasnell Feb 18, 2020
7eed9d6
fs: fix WriteStream autoClose order
ronag Feb 14, 2020
84197ea
test: mark test-timers-blocking-callback flaky on osx
MylesBorins Mar 11, 2020
55a8ca8
src: elevate v8 namespace
RamanandPatil Mar 2, 2020
0a00552
stream: do not swallow errors with async iterators and pipeline
mcollina Mar 2, 2020
625d8f7
src: discard tasks posted to platform TaskRunner during shutdown
addaleax Feb 18, 2020
d8c927b
Revert "src: keep main-thread Isolate attached to platform during Dis…
addaleax Feb 18, 2020
c70cfd2
tools: update ESLint to 7.0.0-alpha.0
cjihrig Feb 28, 2020
cac1d01
tools: update ESLint to 7.0.0-alpha.1
cjihrig Feb 28, 2020
814bb4a
tools: update ESLint to 7.0.0-alpha.2
cjihrig Feb 28, 2020
d3c4210
tools: enable default-case-last lint rule
cjihrig Feb 28, 2020
35d0569
tools: enable no-useless-backreference lint rule
cjihrig Feb 28, 2020
94f3eed
fs: make fs.read params optional
lholmquist Jan 16, 2020
d66daa5
build: support android build on ndk version equal or above 23
forfun414 Jan 26, 2020
c3aa3e7
src: remove unused include from node_file.cc
bnoordhuis Feb 15, 2020
fa376f4
src: fix -Wmaybe-uninitialized compiler warning
bnoordhuis Feb 15, 2020
38329bd
doc: prevent tables from shrinking page
davidgilbertson Feb 18, 2020
3fa57ee
doc: add entry for `AsyncHook` class
HarshithaKP Feb 19, 2020
ceca1c3
test: improve test-fs-existssync-false.js
himself65 Feb 20, 2020
35bea07
doc: add support encoding link on string_decoder.md
himself65 Feb 22, 2020
5bc5161
doc: improve Buffer documentation
addaleax Mar 4, 2020
49a07f7
http, async_hooks: remove unneeded reference to wrapping resource
Flarna Mar 2, 2020
2248ba7
src: fix missing extra ca in tls.rootCertificates
ebickle Mar 3, 2020
fa78aa4
doc: clarify windows specific behaviour
sam-github Mar 4, 2020
af73ed6
doc: clear up child_process command resolution
lundibundi Mar 4, 2020
fe34da8
build: add mjs extension to lint-js
nschonni Mar 8, 2020
4c2e4d1
esm: remove unused parameter on module.instantiate
himself65 Mar 8, 2020
893e918
doc: include the error type in the request.resolve doc
trusktr Mar 8, 2020
478f1e7
async_hooks: avoid resource reuse by FileHandle
Flarna Feb 18, 2020
079bb31
build: remove empty line on node.gyp file
juanarbol Feb 25, 2020
025f658
src: fix spawnSync CHECK when SIGKILL fails
bnoordhuis Feb 13, 2020
ce686c0
crypto: optimize sign.update() and verify.update()
bnoordhuis Feb 13, 2020
e83671c
src: DRY crypto Update() methods
bnoordhuis Feb 13, 2020
77e5b50
doc,test: add server.timeout property to http2 public API
puzpuzpuz Feb 8, 2020
66fe2d9
stream: avoid destroying http1 objects
ronag Mar 11, 2020
fab8c83
stream: avoid destroying writable source
ronag Mar 11, 2020
4a53612
2020-03-11 Version 13.11.0 (Current)
MylesBorins Mar 10, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: remove em dashes
Our documentation uses em dashes inconsistently. They are treated
inconsistently typographically too. (For example, they are sometimes
surrounded by spaces and sometimes not.) They are also often confused
with ordinary hyphens such as in the CHANGELOG, where they are
inadvertently mixed together in a single list. The difference is
not obvious in the raw markdown but is very noticeable when rendered,
appearing to be a typographical error (which it in fact is).

The em dash is never needed. There are always alternatives. Remove em
dashes entirely.

PR-URL: #32080
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Mar 9, 2020
commit 50094de274309b417cfdd4b1b3bdb550a6b60594
26 changes: 13 additions & 13 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,19 @@

Select a Node.js version below to view the changelog history:

* [Node.js 13](doc/changelogs/CHANGELOG_V13.md) - **Current**
* [Node.js 12](doc/changelogs/CHANGELOG_V12.md) - **Long Term Support**
* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) - End-of-Life
* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) Long Term Support
* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) End-of-Life
* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) — Long Term Support
* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) End-of-Life
* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) End-of-Life
* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) End-of-Life
* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) End-of-Life
* [io.js](doc/changelogs/CHANGELOG_IOJS.md) End-of-Life
* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md) End-of-Life
* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md) End-of-Life
* [Node.js 13](doc/changelogs/CHANGELOG_V13.md) **Current**
* [Node.js 12](doc/changelogs/CHANGELOG_V12.md) **Long Term Support**
* [Node.js 11](doc/changelogs/CHANGELOG_V11.md) End-of-Life
* [Node.js 10](doc/changelogs/CHANGELOG_V10.md) Long Term Support
* [Node.js 9](doc/changelogs/CHANGELOG_V9.md) End-of-Life
* [Node.js 8](doc/changelogs/CHANGELOG_V8.md) End-of-Life
* [Node.js 7](doc/changelogs/CHANGELOG_V7.md) End-of-Life
* [Node.js 6](doc/changelogs/CHANGELOG_V6.md) End-of-Life
* [Node.js 5](doc/changelogs/CHANGELOG_V5.md) End-of-Life
* [Node.js 4](doc/changelogs/CHANGELOG_V4.md) End-of-Life
* [io.js](doc/changelogs/CHANGELOG_IOJS.md) End-of-Life
* [Node.js 0.12](doc/changelogs/CHANGELOG_V012.md) End-of-Life
* [Node.js 0.10](doc/changelogs/CHANGELOG_V010.md) End-of-Life
* [Archive](doc/changelogs/CHANGELOG_ARCHIVE.md)

Please use the following table to find the changelog for a specific Node.js
Expand Down
2 changes: 1 addition & 1 deletion doc/api/addons.md
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ require('./build/Release/addon');
Once the source code has been written, it must be compiled into the binary
`addon.node` file. To do so, create a file called `binding.gyp` in the
top-level of the project describing the build configuration of the module
using a JSON-like format. This file is used by [node-gyp][] a tool written
using a JSON-like format. This file is used by [node-gyp][], a tool written
specifically to compile Node.js Addons.

```json
Expand Down
6 changes: 3 additions & 3 deletions doc/api/errors.md
Original file line number Diff line number Diff line change
Expand Up @@ -533,14 +533,14 @@ program. For a comprehensive list, see the [`errno`(3) man page][].
`ulimit -n 2048` in the same shell that will run the Node.js process.

* `ENOENT` (No such file or directory): Commonly raised by [`fs`][] operations
to indicate that a component of the specified pathname does not exist — no
to indicate that a component of the specified pathname does not exist. No
entity (file or directory) could be found by the given path.

* `ENOTDIR` (Not a directory): A component of the given pathname existed, but
was not a directory as expected. Commonly raised by [`fs.readdir`][].

* `ENOTEMPTY` (Directory not empty): A directory with entries was the target
of an operation that requires an empty directory usually [`fs.unlink`][].
of an operation that requires an empty directory, usually [`fs.unlink`][].

* `ENOTFOUND` (DNS lookup failed): Indicates a DNS failure of either
`EAI_NODATA` or `EAI_NONAME`. This is not a standard POSIX error.
Expand All @@ -555,7 +555,7 @@ program. For a comprehensive list, see the [`errno`(3) man page][].

* `ETIMEDOUT` (Operation timed out): A connect or send request failed because
the connected party did not properly respond after a period of time. Usually
encountered by [`http`][] or [`net`][] — often a sign that a `socket.end()`
encountered by [`http`][] or [`net`][]. Often a sign that a `socket.end()`
was not properly called.

## Class: `TypeError`
Expand Down
6 changes: 3 additions & 3 deletions doc/api/http.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ To use the HTTP server and client one must `require('http')`.
The HTTP interfaces in Node.js are designed to support many features
of the protocol which have been traditionally difficult to use.
In particular, large, possibly chunk-encoded, messages. The interface is
careful to never buffer entire requests or responses the
careful to never buffer entire requests or responses, so the
user is able to stream data.

HTTP message headers are represented by an object like this:
Expand Down Expand Up @@ -882,7 +882,7 @@ added: v0.1.29

Sends a chunk of the body. By calling this method
many times, a request body can be sent to a
server — in that case it is suggested to use the
server. In that case, it is suggested to use the
`['Transfer-Encoding', 'chunked']` header line when
creating the request.

Expand Down Expand Up @@ -1214,7 +1214,7 @@ added: v0.1.17

* Extends: {Stream}

This object is created internally by an HTTP server not by the user. It is
This object is created internally by an HTTP server, not by the user. It is
passed as the second parameter to the [`'request'`][] event.

### Event: `'close'`
Expand Down
2 changes: 1 addition & 1 deletion doc/api/http2.md
Original file line number Diff line number Diff line change
Expand Up @@ -3008,7 +3008,7 @@ added: v8.4.0

* Extends: {Stream}

This object is created internally by an HTTP server not by the user. It is
This object is created internally by an HTTP server, not by the user. It is
passed as the second parameter to the [`'request'`][] event.

#### Event: `'close'`
Expand Down
2 changes: 1 addition & 1 deletion doc/api/modules.md
Original file line number Diff line number Diff line change
Expand Up @@ -945,7 +945,7 @@ added: v0.3.7
* {Object}

Provides general utility methods when interacting with instances of
`Module` the `module` variable often seen in file modules. Accessed
`Module`, the `module` variable often seen in file modules. Accessed
via `require('module')`.

### `module.builtinModules`
Expand Down
2 changes: 1 addition & 1 deletion doc/api/net.md
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,7 @@ added: v0.1.90
* Returns: {boolean}

Sends data on the socket. The second parameter specifies the encoding in the
case of a string — it defaults to UTF8 encoding.
case of a string. It defaults to UTF8 encoding.

Returns `true` if the entire data was flushed successfully to the kernel
buffer. Returns `false` if all or part of the data was queued in user memory.
Expand Down
4 changes: 2 additions & 2 deletions doc/api/path.md
Original file line number Diff line number Diff line change
Expand Up @@ -389,7 +389,7 @@ path.parse('/home/user/dir/file.txt');
│ root │ │ name │ ext │
" / home/user/dir / file .txt "
└──────┴──────────────┴──────┴─────┘
(all spaces in the "" line should be ignored — they are purely for formatting)
(All spaces in the "" line should be ignored. They are purely for formatting.)
```

On Windows:
Expand All @@ -411,7 +411,7 @@ path.parse('C:\\path\\dir\\file.txt');
│ root │ │ name │ ext │
" C:\ path\dir \ file .txt "
└──────┴──────────────┴──────┴─────┘
(all spaces in the "" line should be ignored — they are purely for formatting)
(All spaces in the "" line should be ignored. They are purely for formatting.)
```

A [`TypeError`][] is thrown if `path` is not a string.
Expand Down
2 changes: 1 addition & 1 deletion doc/api/process.md
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ rejection handler.

There is no notion of a top level for a `Promise` chain at which rejections can
always be handled. Being inherently asynchronous in nature, a `Promise`
rejection can be handled at a future point in time possibly much later than
rejection can be handled at a future point in time, possibly much later than
the event loop turn it takes for the `'unhandledRejection'` event to be emitted.

Another way of stating this is that, unlike in synchronous code where there is
Expand Down
2 changes: 1 addition & 1 deletion doc/api/url.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ WHATWG URL's `origin` property includes `protocol` and `host`, but not
├─────────────┴─────────────────────┴────────────────────────┴──────────┴────────────────┴───────┤
│ href │
└────────────────────────────────────────────────────────────────────────────────────────────────┘
(all spaces in the "" line should be ignored — they are purely for formatting)
(All spaces in the "" line should be ignored. They are purely for formatting.)
```

Parsing the URL string using the WHATWG API:
Expand Down
2 changes: 1 addition & 1 deletion doc/guides/backporting-to-release-lines.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ replace that with the staging branch for the targeted release line.
9. Open a pull request:
1. Be sure to target the `v10.x-staging` branch in the pull request.
1. Include the backport target in the pull request title in the following
format `[v10.x backport] <commit title>`.
format: `[v10.x backport] <commit title>`.
Example: `[v10.x backport] process: improve performance of nextTick`
1. Check the checkbox labeled "Allow edits from maintainers".
1. In the description add a reference to the original PR.
Expand Down
4 changes: 2 additions & 2 deletions doc/guides/contributing/issues.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ around it. Some contributors may have differing opinions about the issue,
including whether the behavior being seen is a bug or a feature. This discussion
is part of the process and should be kept focused, helpful, and professional.

Short, clipped responsesthat provide neither additional context nor supporting
detailare not helpful or professional. To many, such responses are simply
Short, clipped responses that provide neither additional context nor supporting
detail are not helpful or professional. To many, such responses are simply
annoying and unfriendly.

Contributors are encouraged to help one another make forward progress as much
Expand Down
8 changes: 2 additions & 6 deletions doc/guides/doc-style-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@
* Outside of the wrapping element if the wrapping element contains only a
fragment of a clause.
* Documents must start with a level-one heading.
* Prefer affixing links to inlining links — prefer `[a link][]` to
`[a link](http://example.com)`.
* Prefer affixing links (`[a link][]`) to inlining links
(`[a link](http://example.com)`).
* When documenting APIs, update the YAML comment associated with the API as
appropriate. This is especially true when introducing or deprecating an API.
* Use [Em dashes][] ("—" or `Option+Shift+"-"` on macOS) surrounded by spaces,
as per [The New York Times Manual of Style and Usage][].
* For code blocks:
* Use language aware fences. ("```js")
* Code need not be complete. Treat code blocks as an illustration or aid to
Expand Down Expand Up @@ -67,9 +65,7 @@

See also API documentation structure overview in [doctools README][].

[Em dashes]: https://en.wikipedia.org/wiki/Dash#Em_dash
[Javascript type]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Grammar_and_types#Data_structures_and_types
[serial commas]: https://en.wikipedia.org/wiki/Serial_comma
[The New York Times Manual of Style and Usage]: https://en.wikipedia.org/wiki/The_New_York_Times_Manual_of_Style_and_Usage
[plugin]: https://editorconfig.org/#download
[doctools README]: ../tools/doc/README.md
2 changes: 1 addition & 1 deletion doc/guides/maintaining-icu.md
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ following the steps above in the prior section of this document ought to be
repeatable without concern for overriding a patch.

2. **Verifiability.** Given the number of files modified in an ICU PR,
a floating patch could easily be missed or dropped altogether next time
a floating patch could easily be missed or dropped altogether next time
something is landed.

3. **Compatibility.** There are a number of ways that ICU can be loaded into
Expand Down
2 changes: 1 addition & 1 deletion tools/doc/versions.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ module.exports = {
}
}
const ltsRE = /Long Term Support/i;
const versionRE = /\* \[Node\.js ([0-9.]+)\][^-—]+[-—]\s*(.*)\r?\n/g;
const versionRE = /\* \[Node\.js ([0-9.]+)\]\S+ (.*)\r?\n/g;
_versions = [];
let match;
while ((match = versionRE.exec(changelog)) != null) {
Expand Down