Skip to content

test: buffer.write with longer string scenario #32123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 2 commits into from
Closed

test: buffer.write with longer string scenario #32123

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fdbb5e
test: `buffer.write` with longer string scenario
HarshithaKP Mar 6, 2020
877f062
fixup: address review comment
HarshithaKP Mar 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup: address review comment
  • Loading branch information
@HarshithaKP
HarshithaKP committed Mar 9, 2020
commit 877f0626ffeb9b970be0b2e3baa0aa1724aa4947
1 change: 1 addition & 0 deletions test/parallel/test-buffer-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ assert.strictEqual(z.write('\u0001', 3, 'ucs2'), 0);
assert.strictEqual(Buffer.compare(z, Buffer.alloc(4, 0)), 0);
// Make sure longer strings are written up to the buffer end.
assert.strictEqual(z.write('abcd', 2), 2);
Comment thread
BridgeAR marked this conversation as resolved.
assert.deepStrictEqual([...z], [0, 0, 0x61, 0x62]);

// Large overrun could corrupt the process
assert.strictEqual(Buffer.alloc(4)
Expand Down