Skip to content

[WIP] deps: update V8 to 8.0 #32095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmarchini wants to merge 22 commits into from
Closed

[WIP] deps: update V8 to 8.0 #32095

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7d7d748
deps: update V8 to 8.0.426.26
mmarchini Mar 4, 2020
d77064c
build: reset embedder string to "-node.0"
mmarchini Mar 4, 2020
03b51c2
src: update NODE_MODULE_VERSION to 83
mmarchini Mar 4, 2020
997b2b5
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
60f3e5e
deps: V8: silence irrelevant warnings
targos Mar 27, 2019
8ceed05
deps: patch V8 to run on older XCode versions
ryzokuken Sep 14, 2019
be1fd19
build: enable backtrace when V8 is built for PPC and S390x
targos Oct 29, 2019
7690bcb
tools: update V8 gypfiles for V8 8.0
targos Oct 18, 2019
f24c774
src: stop overriding deprecated V8 methods
backes Dec 2, 2019
3ab0e61
Revert "assert: fix line number calculation after V8 upgrade"
targos Dec 6, 2019
60e7d9f
test: update test-postmortem-metadata.js
cjihrig Dec 8, 2019
35ad809
src: update v8abbr.h for V8 update
cjihrig Dec 8, 2019
3ebef4b
deps: bump minimum icu version to 65
targos Jan 6, 2020
93681bc
src: remove use of deprecated Symbol::Name()
cjihrig Dec 14, 2019
e9b7f47
Update tests for larger Buffers
jakobkummerow Jan 20, 2020
6ae7004
Remove checks for deserializing wasm
backes Jan 22, 2020
432a7b5
Avoid calling deprecated method
backes Feb 3, 2020
57613f5
Remove deprecated wasm type check
backes Feb 6, 2020
2cbbee2
Remove test
backes Feb 6, 2020
819820d
test: mark test-inspector-multisession-ws as flaky
mmarchini Mar 4, 2020
fdc1554
tools: update v8.gyp
richardlau Jan 17, 2020
1d54faf
deps: V8: cherry-pick e8e324aa9d5f
mmarchini Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove checks for deserializing wasm 
Serialization support of WasmModuleObjects will be removed in
https://crrev.com/c/2013110, thus we need to stop testing for that.
  • Loading branch information
@backes @mmarchini
backes authored and mmarchini committed Mar 4, 2020
commit 6ae70047f79f566fa274ffe51b727f5d3873c142
18 changes: 11 additions & 7 deletions test/parallel/test-v8-serdes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
'use strict';

const common = require('../common');
const fixtures = require('../common/fixtures');
// const fixtures = require('../common/fixtures');
const { internalBinding } = require('internal/test/binding');
const assert = require('assert');
const v8 = require('v8');
Expand All @@ -12,7 +12,7 @@ const os = require('os');
const circular = {};
circular.circular = circular;

const wasmModule = new WebAssembly.Module(fixtures.readSync('simple.wasm'));
// const wasmModule = new WebAssembly.Module(fixtures.readSync('simple.wasm'));

const objects = [
{ foo: 'bar' },
Expand All @@ -23,8 +23,7 @@ const objects = [
undefined,
null,
42,
circular,
wasmModule
circular
];

const hostObject = new (internalBinding('js_stream').JSStream)();
Expand Down Expand Up @@ -238,7 +237,12 @@ const deserializerTypeError =
}

{
const deserializedWasmModule = v8.deserialize(v8.serialize(wasmModule));
const instance = new WebAssembly.Instance(deserializedWasmModule);
assert.strictEqual(instance.exports.add(10, 20), 30);
// V8 is removing support for serializing wasm modules via the value
// serializer. Once this is complete (https://crrev.com/c/2013110), we can
// re-add this test:
// assert.throws(
// () => v8.serialize(wasmModule), {
// constructor: Error,
// message: '#<Module> could not be cloned.'
// });
}