Skip to content

module: improve error for invalid package targets #32052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MylesBorins wants to merge 9 commits into from
Closed

module: improve error for invalid package targets #32052

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
974e6c0
module: improve error for invalid package targets
MylesBorins Apr 17, 2020
c55afba
fixup: lint issues
MylesBorins Apr 17, 2020
91e8e80
fixup: primordials
MylesBorins Apr 17, 2020
bb4a755
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
5ca9689
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
c5f08ce
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
51de45b
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
8e04ec1
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
ef6c799
Update lib/internal/errors.js
MylesBorins Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: lint issues
  • Loading branch information
@MylesBorins
MylesBorins committed Apr 17, 2020
commit c55afbaebb980400df546cf8a67bdf6d8a9ee2df
16 changes: 8 additions & 8 deletions lib/internal/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,8 +1104,8 @@ E('ERR_INVALID_PACKAGE_CONFIG', (path, message, hasMessage = true) => {
}, Error);
E('ERR_INVALID_PACKAGE_TARGET',
(pkgPath, key, subpath, target, base = undefined) => {
const relError = typeof target === 'string'
&& target.length && !target.startsWith('./');
const relError = typeof target === 'string' &&
target.length && !target.startsWith('./');
if (key === null) {
if (subpath !== '') {
return `Invalid "exports" target ${JSONStringify(target)} defined ` +
Expand All @@ -1114,18 +1114,18 @@ E('ERR_INVALID_PACKAGE_TARGET',
} else {
return `Invalid "exports" main target ${target} defined in the ` +
`package config ${pkgPath} imported from ${base}.${relError ?
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
' - targets must start with "./"' : ''}`;
' - targets must start with "./"' : ''}`;
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
}
} else if (key === '.') {
return `Invalid "exports" main target ${JSONStringify(target)} defined ` +
`in the package config ${pkgPath}${sep}package.json${relError ?
Comment thread
guybedford marked this conversation as resolved.
' - targets must start with "./"' : ''}`;
' - targets must start with "./"' : ''}`;
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
} else if (typeof target === 'string' && target !== '' &&
!target.startsWith('./')) {
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
return `Invalid "exports" target ${JSONStringify(target)} defined for '${
StringPrototypeSlice(key, 0, -subpath.length || key.length)}' in the ` +
`package config ${pkgPath}${sep}package.json. ` +
'- targets must start with `./`';
return `Invalid "exports" target ${JSONStringify(target)} defined for '${
StringPrototypeSlice(key, 0, -subpath.length || key.length)}' in the ` +
`package config ${pkgPath}${sep}package.json. ` +
'- targets must start with `./`';
Comment thread
MylesBorins marked this conversation as resolved.
Outdated
} else {
return `Invalid "exports" target ${JSONStringify(target)} defined for '${
StringPrototypeSlice(key, 0, -subpath.length || key.length)}' in the ` +
Expand Down