Skip to content

fs,test: throw rather than assert if condition is possible #32028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

fs,test: throw rather than assert if condition is possible #32028

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
916c161
fs: throw rather than assert on errant monkey-patching
Trott Feb 29, 2020
659f06c
test: remove common.expectsInternal Assertion
Trott Feb 29, 2020
92ffbb8
test: add coverage for FSWatcher exception
Trott Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: add coverage for FSWatcher exception 
Cover an previously uncovered exception possible in the internal start
function for FSWatcher.
  • Loading branch information
@Trott
Trott committed Mar 1, 2020
commit 92ffbb8817daf90361487b4710feb56a8974e36c
22 changes: 22 additions & 0 deletions test/sequential/test-fs-watch.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,3 +132,25 @@ tmpdir.refresh();
);
oldhandle.close(); // clean up
}

{
let oldhandle;
assert.throws(
() => {
const w = fs.watch(__filename, common.mustNotCall());
oldhandle = w._handle;
const protoSymbols =
Object.getOwnPropertySymbols(Object.getPrototypeOf(w));
const kFSWatchStart =
protoSymbols.find((val) => val.toString() === 'Symbol(kFSWatchStart)');
w._handle = {};
w[kFSWatchStart]();
},
{
name: 'TypeError',
code: 'ERR_UNEXPECTED_INSTANCE',
message: 'handle must have FSEvent in its prototype chain',
}
);
oldhandle.close(); // clean up
}