Skip to content

stream: make stream.destroy with callback API public #32021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 7 commits into from
Closed

stream: make stream.destroy with callback API public #32021

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d51ce2
stream: make stream.destroy with callback API public
ronag Feb 29, 2020
54f62fc
fixup: docs
ronag Feb 29, 2020
c020324
fixup: docs
ronag Feb 29, 2020
80cf7f6
fixup: tls test + writable write complete err
ronag Feb 29, 2020
43472c4
fixup: test
ronag Feb 29, 2020
b40a103
fixup: reduce changes
ronag Feb 29, 2020
81de706
fixup: always register eos
ronag Feb 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: tls test + writable write complete err
  • Loading branch information
@ronag
ronag committed Feb 29, 2020
commit 80cf7f68d517a4bd4d54ba6a27c376a37892acd6
4 changes: 3 additions & 1 deletion lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,9 +464,11 @@ function afterWrite(stream, state, count, cb) {
stream.emit('drain');
}

const err = state.destroyed ? new ERR_STREAM_DESTROYED('write') : undefined;
Comment thread
ronag marked this conversation as resolved.
Outdated

while (count-- > 0) {
state.pendingcb--;
cb();
cb(err);
}

if (state.destroyed) {
Expand Down
11 changes: 6 additions & 5 deletions test/parallel/test-tls-writewrap-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ const server = net.createServer(common.mustCall((c) => {
c.destroy();
})).listen(0, common.mustCall(() => {
const c = tls.connect({ port: server.address().port });
c.on('error', () => {
// Otherwise `.write()` callback won't be invoked.
c._undestroy();
});

c.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ECONNRESET');
server.close();
}));

c.write('hello', common.mustCall((err) => {
assert.strictEqual(err.code, 'ECANCELED');
assert.strictEqual(err.code, 'ERR_STREAM_DESTROYED');
server.close();
}));
}));