Skip to content

test: fix flaky test-dns-any.js #32017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Mar 2, 2020
Merged

test: fix flaky test-dns-any.js #32017

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: fix flaky test-dns-any.js 
Remove google.com from domains tested with ANY queries.

Fixes: #31721

PR-URL: #32017
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
@Trott
Trott committed Mar 2, 2020
commit fb74e98243e3fabd5fa45587cf1c68948673662e
22 changes: 0 additions & 22 deletions test/internet/test-dns-any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,28 +115,6 @@ function processResult(res) {
return types;
}

TEST(async function test_google(done) {
function validateResult(res) {
const types = processResult(res);
assert.ok(
types.A && types.AAAA && types.MX && types.NS && types.TXT && types.SOA,
`Missing record type, found ${Object.keys(types)}`);
}

validateResult(await dnsPromises.resolve('google.com', 'ANY'));

const req = dns.resolve(
'google.com',
'ANY',
common.mustCall(function(err, ret) {
assert.ifError(err);
validateResult(ret);
done();
}));

checkWrap(req);
});

TEST(async function test_sip2sip_for_naptr(done) {
function validateResult(res) {
const types = processResult(res);
Expand Down