Skip to content

[v12.x backport] events: allow monitoring error events #32004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flarna wants to merge 4 commits into from
Closed

[v12.x backport] events: allow monitoring error events #32004

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1c14d65
events: allow monitoring error events
Flarna Dec 12, 2019
c483e6d
events: convert errorMonitor to a normal property
Flarna Feb 18, 2020
a9356f4
fixup! events: allow monitoring error events
Flarna Feb 28, 2020
4912594
change common.expectsError to assert.throws
Flarna Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
change common.expectsError to assert.throws
  • Loading branch information
@Flarna
Flarna committed Apr 6, 2020
commit 49125942ac91fc08f26bacf4ac7be05ce936c7aa
2 changes: 1 addition & 1 deletion test/parallel/test-event-emitter-error-monitor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ EE.on(
);

// Verify with no error listener
common.expectsError(
assert.throws(
() => EE.emit('error', theErr), theErr
);

Expand Down