Skip to content

v10.19.1 proposal #31983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BethGriggs wants to merge 18 commits into from
Closed

v10.19.1 proposal #31983

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
db24641
deps: upgrade npm to 6.13.6
ruyadorno Jan 10, 2020
7eac959
deps: upgrade npm to 6.13.7
Jan 28, 2020
2315270
test: try to stabalize test-child-process-fork-exec-path.js
refack Apr 17, 2019
a8fd8a1
test: mark http2 tests as flaky on 10.x
Feb 20, 2020
4b9a779
test: mark tests as flaky
joaocgreis Dec 8, 2019
f1a8791
test: allow EAI_FAIL in test-http-dns-error.js
cjihrig Apr 30, 2019
1cfb457
tls: support TLS min/max protocol defaults in CLI
sam-github May 28, 2019
64744a2
buffer: add {read|write}Big[U]Int64{BE|LE} methods
GaryGSC Nov 11, 2019
3f9cec3
test: add debugging output to test-net-listen-after-destroy-stdin
Trott Feb 8, 2020
20177b9
n-api: turn NAPI_CALL_INTO_MODULE into a function
addaleax Feb 15, 2019
f29fb14
n-api: add APIs for per-instance state management
Jul 15, 2019
dc61e09
v8: fix load elimination liveness checks
bnoordhuis Feb 1, 2020
9b2b66b
deps: V8: cherry-pick d89f4ef1cd62
Feb 12, 2020
5484e06
test: scale keepalive timeouts for slow machines
bnoordhuis Dec 7, 2019
42af3b8
build,win: fix goto exit in vcbuild
joaocgreis Dec 13, 2019
ffa9f9b
doc: fix changelog for v10.18.1
andrewhughes101 Jan 14, 2020
9bd1317
test: mark empty udp tests flaky on OS X
sam-github Feb 24, 2020
f8efcc2
2020-03-??, Version 10.19.1 'Dubnium' (LTS)
BethGriggs Feb 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: try to stabalize test-child-process-fork-exec-path.js 
PR-URL: #27277
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
@refack @BethGriggs
refack authored and BethGriggs committed Feb 20, 2020
commit 2315270cb6bd54858fce2e669e23f34f5ddc2308
58 changes: 27 additions & 31 deletions test/parallel/test-child-process-fork-exec-path.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,45 +21,41 @@

'use strict';
const common = require('../common');

// Test that `fork()` respects the `execPath` option.

const tmpdir = require('../common/tmpdir');
const { addLibraryPath } = require('../common/shared-lib-util');
const assert = require('assert');
const fs = require('fs');
const { COPYFILE_FICLONE } = fs.constants;
const path = require('path');
const tmpdir = require('../common/tmpdir');
const fs = require('fs');
const { fork } = require('child_process');

const msg = { test: 'this' };
const nodePath = process.execPath;
const copyPath = path.join(tmpdir.path, 'node-copy.exe');
const { addLibraryPath } = require('../common/shared-lib-util');

addLibraryPath(process.env);

// Child
if (process.env.FORK) {
assert(process.send);
assert.strictEqual(process.argv[0], copyPath);
assert.strictEqual(process.execPath, copyPath);
assert.ok(process.send);
process.send(msg);
process.exit();
} else {
tmpdir.refresh();
try {
fs.unlinkSync(copyPath);
} catch (e) {
if (e.code !== 'ENOENT') throw e;
}
fs.copyFileSync(nodePath, copyPath, COPYFILE_FICLONE);
fs.chmodSync(copyPath, '0755');

// slow but simple
const envCopy = JSON.parse(JSON.stringify(process.env));
envCopy.FORK = 'true';
const child = require('child_process').fork(__filename, {
execPath: copyPath,
env: envCopy
});
child.on('message', common.mustCall(function(recv) {
assert.deepStrictEqual(msg, recv);
}));
child.on('exit', common.mustCall(function(code) {
fs.unlinkSync(copyPath);
assert.strictEqual(code, 0);
}));
return process.exit();
}

// Parent
tmpdir.refresh();
assert.strictEqual(fs.existsSync(copyPath), false);
fs.copyFileSync(nodePath, copyPath, fs.constants.COPYFILE_FICLONE);
fs.chmodSync(copyPath, '0755');

const envCopy = Object.assign({}, process.env, { 'FORK': 'true' });
const child = fork(__filename, { execPath: copyPath, env: envCopy });
child.on('message', common.mustCall(function(recv) {
assert.deepStrictEqual(recv, msg);
}));
child.on('exit', common.mustCall(function(code) {
assert.strictEqual(code, 0);
}));