Skip to content

test: Worker initialization failure test case #31929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 9 commits into from
Closed

test: Worker initialization failure test case #31929

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f69276b
test: Worker initialization failure test case
HarshithaKP Feb 24, 2020
500e991
fixup: remove unwanted file
HarshithaKP Feb 24, 2020
313d520
fixup: address review comments
HarshithaKP Feb 25, 2020
44042ca
fixup: address review comments
HarshithaKP Feb 26, 2020
6a7f905
fixup: cover EMFILE failures generically
HarshithaKP Feb 26, 2020
6a6efb9
fixup: address review comment
HarshithaKP Feb 27, 2020
d356e7e
fixup: address review comment
HarshithaKP Feb 27, 2020
520a906
fixup: address review comments
HarshithaKP Mar 11, 2020
1c804df
fixup: address review comment
HarshithaKP Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: address review comments
  • Loading branch information
@HarshithaKP
HarshithaKP committed Feb 26, 2020
commit 44042cae1fe27e2c4816fd1831e7924740229eb2
8 changes: 4 additions & 4 deletions test/parallel/test-worker-init-failure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ if (process.argv[2] === 'child') {
}
Comment thread
addaleax marked this conversation as resolved.

} else {
// Limit the number of open files, to force workers to fail
// Limit the number of open files, to force workers to fail.
let testCmd = `ulimit -n ${OPENFILES} && `;

Copy link
Copy Markdown
Member

@lundibundi lundibundi Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit:

Suggested change

Copy link
Copy Markdown
Member Author

@HarshithaKP HarshithaKP Mar 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lundibundi, thanks. Removed the extra line.

testCmd += `${process.execPath} ${__filename} child`;
Expand All @@ -45,15 +45,15 @@ if (process.argv[2] === 'child') {
let stderr = '';

cp.on('exit', common.mustCall((code, signal) => {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
if (stdout !== '')
console.log(`child stdout: ${stdout}`);
if (stderr !== '')
console.log(`child stderr: ${stderr}`);
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
}));

// Turn on the child streams for debugging purpose
// Turn on the child streams for debugging purposes.
cp.stderr.on('data', (chunk) => {
stdout += chunk;
});
Expand Down