fixup: disable experimental-modules flag removal

nodejs · guybedford · Feb 18, 2020 · Feb 26, 2020 · Feb 26, 2020 · Feb 26, 2020
commit 98b1f93d23ad2a4de8ac2d29079c8ca887de14f1
diff --git a/lib/internal/process/esm_loader.js b/lib/internal/process/esm_loader.js
@@ -24,6 +24,12 @@ exports.initializeImportMetaObject = function(wrap, meta) {
 
 exports.importModuleDynamicallyCallback = async function(wrap, specifier) {
   assert(calledInitialize === true || !userLoader);
+  if (!calledInitialize) {
+    process.emitWarning(
+      'The ESM module loader is experimental.',
+      'ExperimentalWarning', undefined);
+    calledInitialize = true;
+  }
   calledInitialize = true;
   const { callbackMap } = internalBinding('module_wrap');
   if (callbackMap.has(wrap)) {
@@ -43,6 +49,9 @@ let calledInitialize = false;
 exports.initializeLoader = initializeLoader;
 async function initializeLoader() {
   assert(calledInitialize === false);
+  process.emitWarning(
+    'The ESM module loader is experimental.',
+    'ExperimentalWarning', undefined);
   calledInitialize = true;
   if (!userLoader)
     return;

diff --git a/test/es-module/test-esm-dynamic-import.js b/test/es-module/test-esm-dynamic-import.js
@@ -42,6 +42,8 @@ function expectFsNamespace(result) {
 // For direct use of import expressions inside of CJS or ES modules, including
 // via eval, all kinds of specifiers should work without issue.
 (function testScriptOrModuleImport() {
+  common.expectWarning('ExperimentalWarning',
+                       'The ESM module loader is experimental.');
   // Importing another file, both direct & via eval
   // expectOkNamespace(import(relativePath));
   expectOkNamespace(eval(`import("${relativePath}")`));

diff --git a/test/es-module/test-esm-nowarn-exports.mjs b/test/es-module/test-esm-nowarn-exports.mjs
@@ -16,7 +16,7 @@ child.stderr.on('data', (data) => {
 child.on('close', (code, signal) => {
   strictEqual(code, 0);
   strictEqual(signal, null);
-  ok(!stderr.toString().includes(
+  ok(stderr.toString().includes(
     'ExperimentalWarning: The ESM module loader is experimental'
   ));
   ok(!stderr.toString().includes(

diff --git a/test/message/async_error_sync_esm.out b/test/message/async_error_sync_esm.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 Error: test
     at one (*fixtures*async-error.js:4:9)
     at two (*fixtures*async-error.js:17:9)

diff --git a/test/message/esm_display_syntax_error.out b/test/message/esm_display_syntax_error.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 file:///*/test/message/esm_display_syntax_error.mjs:2
 await async () => 0;
 ^^^^^

diff --git a/test/message/esm_display_syntax_error_import.out b/test/message/esm_display_syntax_error_import.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 file:///*/test/message/esm_display_syntax_error_import.mjs:5
   notfound
   ^^^^^^^^

diff --git a/test/message/esm_display_syntax_error_module.out b/test/message/esm_display_syntax_error_module.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 file:///*/test/fixtures/es-module-loaders/syntax-error.mjs:2
 await async () => 0;
 ^^^^^

diff --git a/test/message/esm_loader_not_found.out b/test/message/esm_loader_not_found.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 (node:*) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
 internal/modules/esm/resolve.js:*
   let url = moduleWrapResolve(specifier, parentURL);

diff --git a/test/message/esm_loader_syntax_error.out b/test/message/esm_loader_syntax_error.out
@@ -1,3 +1,4 @@
+(node:*) ExperimentalWarning: The ESM module loader is experimental.
 (node:*) ExperimentalWarning: --experimental-loader is an experimental feature. This feature could change at any time
 file://*/test/fixtures/es-module-loaders/syntax-error.mjs:2
 await async () => 0;