Skip to content

test: remove common.PORT from test-net-write-callbacks.js #31839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Feb 20, 2020
Merged

test: remove common.PORT from test-net-write-callbacks.js #31839

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove common.PORT from test-net-write-callbacks.js 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
  • Loading branch information
@Trott
Trott committed Feb 20, 2020
commit 1c4e984ed970612f129db2ba6f684311418ed3a2
6 changes: 3 additions & 3 deletions test/pummel/test-net-write-callbacks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
const common = require('../common');
require('../common');
const net = require('net');
const assert = require('assert');

Expand Down Expand Up @@ -55,8 +55,8 @@ function makeCallback(c) {
};
}

server.listen(common.PORT, function() {
const client = net.createConnection(common.PORT);
server.listen(0, function() {
const client = net.createConnection(server.address().port);

client.on('connect', function() {
for (let i = 0; i < N; i++) {
Expand Down