Skip to content

[12.x] module: self resolve flag as experimental modules #31757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 1 commit into from
Closed

[12.x] module: self resolve flag as experimental modules #31757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
module: 12.x self resolve flag as experimental modules
  • Loading branch information
@guybedford
guybedford committed Feb 12, 2020
commit 052e1a9e644cea95546f57ff4a39beec5775c141
1 change: 1 addition & 0 deletions lib/internal/modules/cjs/loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,7 @@ function resolveBasePath(basePath, exts, isMain, trailingSlash, request) {
}

function trySelf(parentPath, isMain, request) {
if (!experimentalModules) return false;
const { data: pkg, path: basePath } = readPackageScope(parentPath) || {};
if (!pkg || pkg.exports === undefined) return false;
if (typeof pkg.name !== 'string') return false;
Expand Down
16 changes: 16 additions & 0 deletions test/es-module/test-esm-flagged-self.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict';

require('../common');
const assert = require('assert');
const path = require('path');
const { createRequireFromPath } = require('module');

const fixturesRequire =
createRequireFromPath(path.resolve(__dirname, '../fixtures/_'));

try {
fixturesRequire('pkgexports/resolve-self');
assert(false);
} catch (e) {
assert.strictEqual(e.code, 'MODULE_NOT_FOUND');
}