Skip to content

test: remove common.PORT from some pummel tests #31749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 4 commits into from
Feb 18, 2020
+15 −14
Merged

test: remove common.PORT from some pummel tests #31749

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
794bfac
test: remove common.PORT from test-net-timeout
Trott Feb 12, 2020
76fd17a
test: remove common.PORT from test-net-throttle
Trott Feb 12, 2020
a092886
test: remove common.PORT from test-tls-server-large-request
Trott Feb 12, 2020
af19f41
test: remove common.PORT from test-net-pause
Trott Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test: remove common.PORT from test-net-timeout 
Switch test-net-timeout from common.PORT to a port assigned by the
operating system.

PR-URL: #31749
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
@Trott
Trott committed Feb 18, 2020
commit 794bfacb26c4059c2eab7efb475489b7010054c3
9 changes: 5 additions & 4 deletions test/pummel/test-net-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.

'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const net = require('net');

Expand Down Expand Up @@ -54,10 +54,11 @@ const echo_server = net.createServer((socket) => {
});
});

echo_server.listen(common.PORT, () => {
console.log(`server listening at ${common.PORT}`);
echo_server.listen(0, () => {
const port = echo_server.address().port;
console.log(`server listening at ${port}`);

const client = net.createConnection(common.PORT);
const client = net.createConnection(port);
client.setEncoding('UTF8');
client.setTimeout(0); // Disable the timeout for client
client.on('connect', () => {
Expand Down