Skip to content

util: add coverage for util.inspect.colors alias setter #31743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 2 commits into from
Closed

util: add coverage for util.inspect.colors alias setter #31743

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0039732
util: add coverage for util.inspect.colors alias setter
Trott Feb 11, 2020
333b75d
fixup! util: add coverage for util.inspect.colors alias setter
Trott Feb 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
util: add coverage for util.inspect.colors alias setter 
Add test to confirm that the setter for aliases in `util.inspect.colors`
keeps the alias reference-equal to the target value.

Refs: https://coverage.nodejs.org/coverage-5b0308cd823a5110/lib/internal/util/inspect.js.html#L357
Refs: https://codecov.io/gh/nodejs/node/src/5b0308cd823a511098dadf9ddd5a35e3a9dbb424/lib/internal/util/inspect.js#L357
  • Loading branch information
@Trott
Trott committed Feb 11, 2020
commit 0039732046e1a37e0daa435846deb3642265955c
18 changes: 18 additions & 0 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2723,3 +2723,21 @@ assert.strictEqual(
'\x1B[2mdef: \x1B[33m5\x1B[39m\x1B[22m }'
);
}

// Test changing util.inspect.colors colors and aliases. Since this might have
// side effects, we do it last.
{
Comment thread
Trott marked this conversation as resolved.
const colors = util.inspect.colors;
// "grey" is reference-equal alias of "gray".
assert.strictEqual(colors.grey, colors.gray);

// Assigninging one should assign the other. This tests that the alias setter
// function keeps things reference-equal.
colors.gray = [0, 0];
assert.deepStrictEqual(colors.gray, [0, 0]);
assert.strictEqual(colors.grey, colors.gray);

colors.grey = [1, 1];
assert.deepStrictEqual(colors.grey, [1, 1]);
assert.strictEqual(colors.grey, colors.gray);
}