Skip to content

src: Check for overflow when resizing AliasedBufferBase #31740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amdoku wants to merge 3 commits into from
Closed

src: Check for overflow when resizing AliasedBufferBase #31740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fac0992
src: Check for overflow when extending AliasedBufferBase
amdoku Feb 11, 2020
2f23066
src: Add aliased-buffer-overflow abort test
amdoku Feb 12, 2020
0382006
src: Add test/abort build tasks
amdoku Feb 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: Check for overflow when extending AliasedBufferBase 
When resizing an aliased_buffer check if the new size will overflow.
  • Loading branch information
@amdoku
amdoku committed Feb 14, 2020
commit fac0992c285686dd51ab37478d031674003972c1
3 changes: 2 additions & 1 deletion src/aliased_buffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,8 @@ class AliasedBufferBase {
const v8::HandleScope handle_scope(isolate_);

const size_t old_size_in_bytes = sizeof(NativeT) * count_;
const size_t new_size_in_bytes = sizeof(NativeT) * new_capacity;
const size_t new_size_in_bytes = MultiplyWithOverflowCheck(sizeof(NativeT),
new_capacity);

// allocate v8 new ArrayBuffer
v8::Local<v8::ArrayBuffer> ab = v8::ArrayBuffer::New(
Expand Down