Skip to content

util: throw if unreachable TypedArray checking code is reached #31737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 1 commit into from
Closed

util: throw if unreachable TypedArray checking code is reached #31737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
util: throw if unreachable TypedArray checking code is reached 
If a comparison code path that is supposed to be unreachable is reached,
throw. Add a c8 comment to ignore coverage for the line, as it
should be unreachable.
  • Loading branch information
@Trott
Trott committed Feb 11, 2020
commit 4601ea1e1397b552e5509ed79e826dcca198fae7
7 changes: 6 additions & 1 deletion lib/internal/util/comparisons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const {
} = primordials;

const { compare } = internalBinding('buffer');
const assert = require('internal/assert');
const types = require('internal/util/types');
const {
isAnyArrayBuffer,
Expand Down Expand Up @@ -145,7 +146,11 @@ function isIdenticalTypedArrayType(a, b) {
return check(b);
}
}
return false;
/* c8 ignore next */
assert.fail(
`Unknown TypedArray type checking ${a[SymbolToStringTag]} ${a}\n` +
`and ${b[SymbolToStringTag]} ${b}`
);
}

// Notes: Type tags are historical [[Class]] properties that can be set by
Expand Down