Skip to content

test: increase test timeout to prevent flakiness #31716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 1 commit into from
Closed

test: increase test timeout to prevent flakiness #31716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: increase test timeout to prevent flakiness 
This increases the waiting time for each event from 500 to 750 ms.
The former timeout could be hit on very slow machines with high load.
  • Loading branch information
@BridgeAR
BridgeAR committed Feb 10, 2020
commit 25fb33ca28d0462210f6939f61b8270f75f05658
2 changes: 1 addition & 1 deletion test/parallel/test-repl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,7 +861,7 @@ function event(ee, expected) {
const data = inspect(expected, { compact: false });
const msg = `The REPL did not reply as expected for:\n\n${data}`;
reject(new Error(msg));
}, common.platformTimeout(500));
}, common.platformTimeout(750));
ee.once('data', common.mustCall((...args) => {
clearTimeout(timeout);
resolve(...args);
Expand Down