Skip to content

test: improve assertion message in test-dns-any #31697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Trott merged 1 commit into from
Feb 10, 2020
Merged

test: improve assertion message in test-dns-any #31697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: improve assertion message in test-dns-any 
Improve error message from "The expression evaluated to a falsy value"
to a message formatted dynamically that lists the record types found so
that someone investigating can look at the code and determine which
values are missing.

This came up because the test failed in nightly master branch CI but
generally passes. It may prove helpful to know what record types were
missing. (All of them? Just one? Something else?)

PR-URL: #31697
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@Trott
Trott committed Feb 10, 2020
commit 84836df1503467e53e22bdc0723897acc5d756c4
7 changes: 4 additions & 3 deletions test/internet/test-dns-any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ TEST(async function test_google(done) {
function validateResult(res) {
const types = processResult(res);
assert.ok(
types.A && types.AAAA && types.MX &&
types.NS && types.TXT && types.SOA);
types.A && types.AAAA && types.MX && types.NS && types.TXT && types.SOA,
`Missing record type, found ${Object.keys(types)}`);
}

validateResult(await dnsPromises.resolve('google.com', 'ANY'));
Expand All @@ -140,7 +140,8 @@ TEST(async function test_google(done) {
TEST(async function test_sip2sip_for_naptr(done) {
function validateResult(res) {
const types = processResult(res);
assert.ok(types.A && types.NS && types.NAPTR && types.SOA);
assert.ok(types.A && types.NS && types.NAPTR && types.SOA,
`Missing record type, found ${Object.keys(types)}`);
}

validateResult(await dnsPromises.resolve('sip2sip.info', 'ANY'));
Expand Down