Skip to content

doc: Add example to fs.promises.readdir #31552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
conoro wants to merge 3 commits into from
Closed

doc: Add example to fs.promises.readdir #31552

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bdfc73
doc: Add example to fs.promises.readdir
conoro Jan 28, 2020
58b1c1a
Update doc/api/fs.md
conoro Jan 28, 2020
700feab
fixup! Update doc/api/fs.md
Trott Feb 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update doc/api/fs.md 
Co-Authored-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
@conoro @jasnell
conoro and jasnell authored Jan 28, 2020
commit 58b1c1a4d4ec456480aea3e2ccbd2b49daea1a3f
2 changes: 1 addition & 1 deletion doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4929,7 +4929,7 @@ will be passed as `Buffer` objects.
If `options.withFileTypes` is set to `true`, the resolved array will contain
[`fs.Dirent`][] objects.

Example using async iteration:
Example iterating over a directory listing:
Copy link
Copy Markdown
Member

@Trott Trott Jan 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably omit this line and simply show the example code. If you want to include // Iterate over a directory listing. as a comment in the example code, that would be better IMO. The example code and surrounding text should be related but independent.

Comment thread
jasnell marked this conversation as resolved.
Outdated

```js
const fs = require('fs');
Expand Down