Skip to content

stream: fix async iterator return when destroyed earlier #31508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcollina wants to merge 2 commits into from
Closed

stream: fix async iterator return when destroyed earlier #31508

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3df1667
Revert "stream: fix async iterator destroyed error propagation"
mcollina Jan 25, 2020
638ba66
stream: add regression test for async iteration completion
mcollina Jan 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
stream: add regression test for async iteration completion 
A test was missing for an async iterator created after the stream
had emitted 'close'. This was regressed by #31314.

See: #31314
  • Loading branch information
@mcollina
mcollina committed Jan 25, 2020
commit 638ba66e18b019bf5954cb61b9716e0b11338918
19 changes: 19 additions & 0 deletions test/parallel/test-stream-readable-async-iterators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,5 +527,24 @@ async function tests() {
p.then(common.mustCall()).catch(common.mustNotCall());
}

{
// AsyncIterator should finish correctly if destroyed.

const r = new Readable({
objectMode: true,
read() {
}
});

r.destroy();
r.on('close', () => {
const it = r[Symbol.asyncIterator]();
const next = it.next();
next
.then(common.mustCall(({ done }) => assert.strictEqual(done, true)))
.catch(common.mustNotCall());
});
}

// To avoid missing some tests if a promise does not resolve
tests().then(common.mustCall());