Skip to content

http: decode username and password before encoding #31450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
Closed

http: decode username and password before encoding #31450

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17ef5bf
http: decode username and password before encoding
addaleax Jan 21, 2020
76ca736
fixup! http: decode username and password before encoding
addaleax Jan 21, 2020
8ccf69f
fixup! http: decode username and password before encoding
addaleax Jan 23, 2020
5ebbb79
fixup! http: decode username and password before encoding
addaleax Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! http: decode username and password before encoding
  • Loading branch information
@addaleax
addaleax committed Jan 21, 2020
commit 76ca7362bc7866c49c7a97010e141b4dac2f1f68
10 changes: 9 additions & 1 deletion doc/api/url.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,12 @@ the URL, use the [`url.search`][] setter. See [`URLSearchParams`][]
documentation for details.

#### `url.username`
<!-- YAML
changes:
- version: REPLACEME
pr-url: https://github.com/nodejs/node/pull/31450
description: When used with `http.request()`, this field will now be
percent-decoded.
Copy link
Copy Markdown
Member

@richardlau richardlau Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing closing -->.

Copy link
Copy Markdown
Member

@bnoordhuis bnoordhuis Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section on http.request() in http.md seems like a more logical place to me for this note.

Copy link
Copy Markdown
Member Author

@addaleax addaleax Jan 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section on http.request() in http.md seems like a more logical place to me for this note.

Why not both? :)


* {string}

Expand All @@ -488,7 +494,8 @@ console.log(myURL.href);
Any invalid URL characters appearing in the value assigned the `username`
property will be [percent-encoded][]. The selection of which
characters to percent-encode may vary somewhat from what the [`url.parse()`][]
and [`url.format()`][] methods would produce.
and [`url.format()`][] methods would produce. When used with
[`http.request()`][], this field will be percent-decoded.

#### `url.toString()`

Expand Down Expand Up @@ -1316,6 +1323,7 @@ console.log(myURL.origin);
[`TypeError`]: errors.html#errors_class_typeerror
[`URLSearchParams`]: #url_class_urlsearchparams
[`array.toString()`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/toString
[`http.request()`]: http.html#http_http_request_options_callback
[`new URL()`]: #url_constructor_new_url_input_base
[`querystring`]: querystring.html
[`require('url').format()`]: #url_url_format_url_options
Expand Down