Skip to content

http: make --insecure-http-parser configurable per-stream or per-server #31448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 4 commits into from
+117 −2
Closed

http: make --insecure-http-parser configurable per-stream or per-server #31448

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
324866d
http: make --insecure-http-parser configurable per-stream or per-server
addaleax Jan 21, 2020
79c6d9b
fixup! http: make --insecure-http-parser configurable per-stream or p…
addaleax Jan 21, 2020
946e815
fixup! http: make --insecure-http-parser configurable per-stream or p…
addaleax Jan 22, 2020
819468e
fixup! http: make --insecure-http-parser configurable per-stream or p…
addaleax Jan 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! http: make --insecure-http-parser configurable per-stream or p… 
…er-server
  • Loading branch information
@addaleax
addaleax committed Jan 22, 2020
commit 946e815d81f07bcf355f21156d14ec5ab4d2fee1
15 changes: 8 additions & 7 deletions doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,10 +2049,10 @@ changes:
* `ServerResponse` {http.ServerResponse} Specifies the `ServerResponse` class
to be used. Useful for extending the original `ServerResponse`. **Default:**
`ServerResponse`.
* `insecureHTTPParser` {boolean} Optionally overrides the value of
[`--insecure-http-parser`][] for requests received by this server, i.e.
whether to accept invalid HTTP headers that must manually be sanitized.
**Default:** false.
* `insecureHTTPParser` {boolean} Use an insecure HTTP parser that accepts
invalid HTTP headers when `true`. Using the insecure parser should be
avoided, see [`--insecure-http-parser`][] for more information.
Comment thread
addaleax marked this conversation as resolved.
Outdated
**Default:** `false`
* `maxHeaderSize` {number} Optionally overrides the value of
[`--max-http-header-size`][] for requests received by this server, i.e.
the maximum length of request headers in bytes.
Expand Down Expand Up @@ -2201,9 +2201,10 @@ changes:
request to. **Default:** `'localhost'`.
* `hostname` {string} Alias for `host`. To support [`url.parse()`][],
`hostname` will be used if both `host` and `hostname` are specified.
* `insecureHTTPParser` {boolean} Optionally overrides the value of
[`--insecure-http-parser`][] for requests received from the server, i.e.
whether to accept invalid HTTP headers that must manually be sanitized.
* `insecureHTTPParser` {boolean} Use an insecure HTTP parser that accepts
invalid HTTP headers when `true`. Using the insecure parser should be
avoided, see [`--insecure-http-parser`][] for more information.
Comment thread
addaleax marked this conversation as resolved.
Outdated
**Default:** `false`
* `localAddress` {string} Local interface to bind for network connections.
* `lookup` {Function} Custom lookup function. **Default:** [`dns.lookup()`][].
* `maxHeaderSize` {number} Optionally overrides the value of
Expand Down