Skip to content

[v12.x] multiple util and assert backports #31431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 15 commits into from
Closed

[v12.x] multiple util and assert backports #31431

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9d82b76
util: fix .format() not always calling toString when it should be
BridgeAR Nov 9, 2019
2859667
benchmark: add more util inspect and format benchmarks
BridgeAR Nov 30, 2019
e110449
util: improve performance inspecting proxies
BridgeAR Nov 30, 2019
62ed6a2
util: never trigger any proxy traps using `format()`
BridgeAR Dec 1, 2019
7d19aba
util: fix built-in detection
BridgeAR Nov 30, 2019
a9d41b7
util: inspect (user defined) prototype properties
BridgeAR Nov 30, 2019
0b08d32
util: refactor inspect code for constistency
BridgeAR Nov 2, 2019
1e2c535
util: add (typed) array length to the default output
BridgeAR Dec 19, 2019
a676531
src: accept single argument in getProxyDetails
BridgeAR Dec 8, 2019
9c9b338
util: improve prototype inspection using `inspect()` and `showHidden`
BridgeAR Dec 26, 2019
32dfdb8
assert: fix generatedMessage property
BridgeAR Jun 14, 2019
ad12514
assert: DRY .throws code
BridgeAR Jun 14, 2019
8b82c85
doc: update assert.throws() examples
BridgeAR Jun 17, 2019
ed2d864
doc: make `AssertionError` a link
BridgeAR Jun 20, 2019
e2970ab
assert: implement `assert.match()` and `assert.doesNotMatch()`
BridgeAR Dec 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
benchmark: add more util inspect and format benchmarks 
This adds a couple of benchmarks to check different options and code
paths.

PR-URL: #30767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
@BridgeAR
BridgeAR committed Jan 20, 2020
commit 2859667b1bcca2238085c6a3ab9ebb4ae9e70224
2 changes: 2 additions & 0 deletions benchmark/util/format.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ const inputs = {
'no-replace-2': ['foobar', 'yeah', 'mensch', 5],
'only-objects': [{ msg: 'This is an error' }, { msg: 'This is an error' }],
'many-%': ['replace%%%%s%%%%many%s%s%s', 'percent'],
'object-to-string': ['foo %s bar', { toString() { return 'bla'; } }],
'object-%s': ['foo %s bar', { a: true, b: false }],
};

const bench = common.createBenchmark(main, {
Expand Down
18 changes: 13 additions & 5 deletions benchmark/util/inspect-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,21 @@
const util = require('util');
const common = require('../common.js');

const bench = common.createBenchmark(main, { n: [2e4] });
const bench = common.createBenchmark(main, {
n: [2e4],
showProxy: [0, 1],
isProxy: [0, 1]
});

function main({ n }) {
const proxyA = new Proxy({}, { get: () => {} });
const proxyB = new Proxy(() => {}, {});
function main({ n, showProxy, isProxy }) {
let proxyA = {};
let proxyB = () => {};
if (isProxy) {
proxyA = new Proxy(proxyA, { get: () => {} });
proxyB = new Proxy(proxyB, {});
}
bench.start();
for (let i = 0; i < n; i += 1)
util.inspect({ a: proxyA, b: proxyB }, { showProxy: true });
util.inspect({ a: proxyA, b: proxyB }, { showProxy });
bench.end(n);
}
4 changes: 3 additions & 1 deletion test/benchmark/test-benchmark-util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,7 @@ runBenchmark('util',
'size=1',
'type=',
'len=1',
'version=native'],
'version=native',
'isProxy=1',
'showProxy=1'],
{ NODEJS_BENCHMARK_ZERO_ALLOWED: 1 });