Skip to content

events: add type check for event name #31428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Flarna wants to merge 3 commits into from
Closed

events: add type check for event name #31428

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b952d9f
events: add type check for event name
Flarna Jan 19, 2020
555e6c5
rename checkType() to checkEventNameType()
Flarna Jan 28, 2020
d301636
perf: use if instead switch
Flarna Jan 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename checkType() to checkEventNameType()
  • Loading branch information
@Flarna
Flarna committed Jan 28, 2020
commit 555e6c57e6df5da4f0d0e9ec7da2633f907b66ca
12 changes: 6 additions & 6 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function checkListener(listener) {
}
}

function checkType(type) {
function checkEventNameType(type) {
// Besides string/symbol also numeric types are seen in the wild
switch (typeof type) {
case 'string':
Expand Down Expand Up @@ -363,7 +363,7 @@ function _addListener(target, type, listener, prepend) {
let events;
let existing;

checkType(type);
checkEventNameType(type);
checkListener(listener);

events = target._events;
Expand Down Expand Up @@ -470,7 +470,7 @@ EventEmitter.prototype.removeListener =
function removeListener(type, listener) {
let originalListener;

checkType(type);
checkEventNameType(type);
checkListener(listener);

const events = this._events;
Expand Down Expand Up @@ -526,7 +526,7 @@ EventEmitter.prototype.off = EventEmitter.prototype.removeListener;
EventEmitter.prototype.removeAllListeners =
function removeAllListeners(type) {
if (arguments.length !== 0) {
checkType(type);
checkEventNameType(type);
}

const events = this._events;
Expand Down Expand Up @@ -574,7 +574,7 @@ EventEmitter.prototype.removeAllListeners =
};

function _listeners(target, type, unwrap) {
checkType(type);
checkEventNameType(type);

const events = target._events;

Expand Down Expand Up @@ -610,7 +610,7 @@ EventEmitter.listenerCount = function(emitter, type) {

EventEmitter.prototype.listenerCount = listenerCount;
function listenerCount(type) {
checkType(type);
checkEventNameType(type);

const events = this._events;

Expand Down