Skip to content

fs: add statfs to fs #31351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SheikhSajid wants to merge 11 commits into from
Closed

fs: add statfs to fs #31351

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f7a3f8e
fs: add statfs to fs
SheikhSajid Jan 7, 2020
7e69ae3
Fix doc
SheikhSajid Jan 14, 2020
3a10e45
Fix typos in doc
SheikhSajid Jan 14, 2020
56665b8
Move oncomplete callback inline
SheikhSajid Jan 14, 2020
5313e93
Remove spare field(s)
SheikhSajid Jan 14, 2020
490d268
Update and fix doc
SheikhSajid Jan 14, 2020
dc6a4a0
Use maybeCallback
SheikhSajid Jan 15, 2020
c27332b
Add tests for statfsSync and bigint varations
SheikhSajid Jan 15, 2020
eed4efb
Fix linting errors
SheikhSajid Jan 15, 2020
8fcea1e
Put StatFs properties in sorted order in docs
SheikhSajid Jan 16, 2020
d4243b7
Reorder properties of output in docs
SheikhSajid Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linting errors
  • Loading branch information
@SheikhSajid
SheikhSajid committed Feb 11, 2020
commit eed4efb5a4f185631b11d9c266f15cb3f6500c32
6 changes: 3 additions & 3 deletions test/parallel/test-fs-promises.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function verifyStatObject(stat) {

function verifyStatfsObject(stat, isBigint = false) {
const valueType = isBigint ? 'bigint' : 'number';

assert.strictEqual(typeof stat, 'object');
assert.strictEqual(typeof stat.type, valueType);
assert.strictEqual(typeof stat.bsize, valueType);
Expand Down Expand Up @@ -140,13 +140,13 @@ async function getHandle(dest) {
await handle.close();
}

// file system stats
// File system stats
{
Comment thread
SheikhSajid marked this conversation as resolved.
Outdated
const statFs = await statfs(dest);
verifyStatfsObject(statFs);
}

// file system stats bigint
// File system stats bigint
{
const statFs = await statfs(dest, { bigint: true });
verifyStatfsObject(statFs, true);
Expand Down
5 changes: 3 additions & 2 deletions test/parallel/test-fs-statfs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ const fs = require('fs');

function verifyStatFsObject(statfs, isBigint = false) {
const valueType = isBigint ? 'bigint' : 'number';

[
'type', 'bsize', 'blocks', 'bfree', 'bavail', 'files', 'ffree'
].forEach((k) => {
assert.ok(statfs.hasOwnProperty(k));
assert.strictEqual(typeof statfs[k], valueType, `${k} should be a ${valueType}`);
assert.strictEqual(typeof statfs[k], valueType,
`${k} should be a ${valueType}`);
});
}

Expand Down