Skip to content

doc: document missing properties in child_process #31342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HarshithaKP wants to merge 4 commits into from
Closed

doc: document missing properties in child_process #31342

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e968865
doc: document missing properties in child_process
HarshithaKP Jan 13, 2020
9a2db08
fixup: address review comments
HarshithaKP Jan 14, 2020
a0b0d68
fixup: address review comment
HarshithaKP Jan 14, 2020
4f9931b
fixup: address review comment
HarshithaKP Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: address review comment
  • Loading branch information
@HarshithaKP
HarshithaKP committed Jan 14, 2020
commit a0b0d68faa3b90af62fe9ec127497cf4786dae52
8 changes: 4 additions & 4 deletions doc/api/child_process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ When the child process is a Node.js instance (e.g. spawned using
[`child_process.fork()`][]), the `process.disconnect()` method can be invoked
within the child process to close the IPC channel as well.

###`subprocess.exitCode`
### `subprocess.exitCode`

* {integer}

Expand Down Expand Up @@ -1375,14 +1375,14 @@ It is also recommended that any `'message'` handlers in the child process
verify that `socket` exists, as the connection may have been closed during the
time it takes to send the connection to the child.

###`subprocess.signalCode`
### `subprocess.signalCode`

* {integer}

The `subprocess.signalCode` property indicates the signal number received by
the child process if any, else null.

###`subprocess.spawnfile`
### `subprocess.spawnfile`

* {string}

Expand All @@ -1396,7 +1396,7 @@ the executable file.
For [`child_process.exec()`][], its value will be the name of the shell
in which the child process is launched.

###`subprocess.spawnargs`
### `subprocess.spawnargs`
Copy link
Copy Markdown
Member

@Trott Trott Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spawnargs should go before spawnfile rather than after it.

Copy link
Copy Markdown
Member Author

@HarshithaKP HarshithaKP Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott, thanks. Placed it in right place.


* {Array}

Expand Down